From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753806AbcILSc3 (ORCPT ); Mon, 12 Sep 2016 14:32:29 -0400 Received: from mail.skyhub.de ([78.46.96.112]:42807 "EHLO mail.skyhub.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751092AbcILSc0 (ORCPT ); Mon, 12 Sep 2016 14:32:26 -0400 Date: Mon, 12 Sep 2016 20:32:23 +0200 From: Borislav Petkov To: Colin King Cc: Mauro Carvalho Chehab , Doug Thompson , linux-edac@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] EDAC: sb_edac: remove null pointer check on array pci_tad Message-ID: <20160912183223.czxdypdftk2qd2f2@pd.tnic> References: <20160908083801.14766-1-colin.king@canonical.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20160908083801.14766-1-colin.king@canonical.com> User-Agent: NeoMutt/ (1.7.0) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Sep 08, 2016 at 09:38:01AM +0100, Colin King wrote: > From: Colin Ian King > > pvt->pci_tad is a NUM_CHANNELS array of struct pci_dev pointers and > hence cannot be null, so the pull pointer check on pci_tad is > redundant. Remove it. > > Signed-off-by: Colin Ian King > --- > drivers/edac/sb_edac.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) Applied, thanks. -- Regards/Gruss, Boris. ECO tip #101: Trim your mails when you reply.