From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759584AbcIMP5k (ORCPT ); Tue, 13 Sep 2016 11:57:40 -0400 Received: from shards.monkeyblade.net ([184.105.139.130]:40502 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759552AbcIMP5g (ORCPT ); Tue, 13 Sep 2016 11:57:36 -0400 Date: Tue, 13 Sep 2016 11:57:35 -0400 (EDT) Message-Id: <20160913.115735.1397234520899437294.davem@davemloft.net> To: gorcunov@gmail.com Cc: dsa@cumulusnetworks.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, eric.dumazet@gmail.com, kuznet@ms2.inr.ac.ru, jmorris@namei.org, yoshfuji@linux-ipv6.org, kaber@trash.net, avagin@openvz.org, stephen@networkplumber.org Subject: Re: [PATCH v3] net: ip, diag -- Add diag interface for raw sockets From: David Miller In-Reply-To: <20160911191714.GC2001@uranus.lan> References: <20160910220528.GB2001@uranus.lan> <20160911191714.GC2001@uranus.lan> X-Mailer: Mew version 6.7 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Tue, 13 Sep 2016 08:57:36 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Cyrill Gorcunov Date: Sun, 11 Sep 2016 22:17:15 +0300 > On Sat, Sep 10, 2016 at 04:28:40PM -0600, David Ahern wrote: >> On 9/10/16 4:05 PM, Cyrill Gorcunov wrote: >> > On Sat, Sep 10, 2016 at 10:31:35AM -0600, David Ahern wrote: >> >> >> >> Would you mind adding the destroy capability as well? The udp version >> >> should be close to what is needed for raw sockets. See udp_diag_destroy >> >> and udp_abort. >> > >> > Should be something like below. Didn't tested it yet so for review only. >> > Will do testing at Monday. >> >> doesn't compile: >> - raw_abort needs to be in a header for ipv6, and >> - inet_sk_diag_fill args have changed due to a recent commit > > Thanks for review, David. I updated against net-next. Please do not post new versions of patches as replies to existing discussions. Instead, make fresh patch postings to the list. Thanks.