From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753680AbcIMBtE (ORCPT ); Mon, 12 Sep 2016 21:49:04 -0400 Received: from mail-pf0-f196.google.com ([209.85.192.196]:36435 "EHLO mail-pf0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751567AbcIMBtB (ORCPT ); Mon, 12 Sep 2016 21:49:01 -0400 Date: Tue, 13 Sep 2016 09:48:55 +0800 From: Peter Chen To: Arnd Bergmann Cc: Greg Kroah-Hartman , Peter Chen , Felipe Balbi , Heikki Krogerus , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] usb: Kconfig: make USB_ULPI_BUS select USB_COMMON Message-ID: <20160913014855.GE25182@b29397-desktop> References: <20160912153649.3163096-1-arnd@arndb.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160912153649.3163096-1-arnd@arndb.de> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Sep 12, 2016 at 05:36:23PM +0200, Arnd Bergmann wrote: > Moving the CONFIG_USB_ULPI_BUS option to the top-level Kconfig file > means that we can enable it without any of the other USB support, > leading to a build error because Kbuild never enters the > drivers/usb/common/ directory without CONFIG_USB_COMMON: > > ERROR: "ulpi_unregister_driver" [drivers/phy/phy-tusb1210.ko] undefined! > ERROR: "__ulpi_register_driver" [drivers/phy/phy-tusb1210.ko] undefined! > ERROR: "ulpi_write" [drivers/phy/phy-tusb1210.ko] undefined! > Thanks, Arnd. I have submitted the fix. https://git.kernel.org/cgit/linux/kernel/git/gregkh/usb.git/commit/?h=usb-next&id=6406c3d226374c28d452b11db3b5ac241ce26191 -- Best Regards, Peter Chen