From: Namhyung Kim <namhyung@kernel.org>
To: Arnaldo Carvalho de Melo <acme@kernel.org>
Cc: Ingo Molnar <mingo@kernel.org>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
Jiri Olsa <jolsa@kernel.org>, LKML <linux-kernel@vger.kernel.org>,
Andi Kleen <andi@firstfloor.org>
Subject: [PATCH 3/7] perf hist: Initialize hierachy tree explicitly
Date: Tue, 13 Sep 2016 16:45:48 +0900 [thread overview]
Message-ID: <20160913074552.13284-4-namhyung@kernel.org> (raw)
In-Reply-To: <20160913074552.13284-1-namhyung@kernel.org>
The hroot_in and hroot_out are root of hiearchy tree of hist entry. But
as hist entry is initialized by copying existing template entry, it
sometimes has non-empty tree and copied it incorrectly. This is a
problem especially when event group is used since it creates dummy
entries from already-processed entries in other event members.
Signed-off-by: Namhyung Kim <namhyung@kernel.org>
---
tools/perf/util/hist.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/tools/perf/util/hist.c b/tools/perf/util/hist.c
index 702ba3a8ead6..37a08f20730a 100644
--- a/tools/perf/util/hist.c
+++ b/tools/perf/util/hist.c
@@ -417,6 +417,8 @@ static int hist_entry__init(struct hist_entry *he,
}
INIT_LIST_HEAD(&he->pairs.node);
thread__get(he->thread);
+ he->hroot_in = RB_ROOT;
+ he->hroot_out = RB_ROOT;
if (!symbol_conf.report_hierarchy)
he->leaf = true;
--
2.9.3
next prev parent reply other threads:[~2016-09-13 7:46 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-13 7:45 [PATCHSET 0/7] perf tools: Support hierarchy report with event group (v2) Namhyung Kim
2016-09-13 7:45 ` [PATCH 1/7] perf hist: Introduce hists__match_hierarchy() Namhyung Kim
2016-09-19 7:48 ` Jiri Olsa
2016-09-20 1:10 ` Namhyung Kim
2016-09-20 21:39 ` [tip:perf/core] perf hists: " tip-bot for Namhyung Kim
2016-09-13 7:45 ` [PATCH 2/7] perf hist: Introduce hists__link_hierarchy() Namhyung Kim
2016-09-19 7:59 ` Jiri Olsa
2016-09-20 1:17 ` Namhyung Kim
2016-09-20 21:39 ` [tip:perf/core] perf hists: " tip-bot for Namhyung Kim
2016-09-13 7:45 ` Namhyung Kim [this message]
2016-09-20 21:40 ` [tip:perf/core] perf hist: Initialize hierarchy tree explicitly tip-bot for Namhyung Kim
2016-09-13 7:45 ` [PATCH 4/7] perf ui/stdio: Always reset output width for hierarchy Namhyung Kim
2016-09-20 21:40 ` [tip:perf/core] " tip-bot for Namhyung Kim
2016-09-13 7:45 ` [PATCH 5/7] perf ui/stdio: Rename print_hierarchy_header() Namhyung Kim
2016-09-20 21:41 ` [tip:perf/core] " tip-bot for Namhyung Kim
2016-09-13 7:45 ` [PATCH 6/7] perf ui/tui: Reset output width for hierarchy Namhyung Kim
2016-09-19 8:05 ` Jiri Olsa
2016-09-20 1:18 ` Namhyung Kim
2016-09-20 14:05 ` Arnaldo Carvalho de Melo
2016-09-13 7:45 ` [PATCH 7/7] perf report: Enable group view with hierarchy Namhyung Kim
2016-09-20 21:41 ` [tip:perf/core] " tip-bot for Namhyung Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160913074552.13284-4-namhyung@kernel.org \
--to=namhyung@kernel.org \
--cc=a.p.zijlstra@chello.nl \
--cc=acme@kernel.org \
--cc=andi@firstfloor.org \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome