From: Sakari Ailus <sakari.ailus@iki.fi>
To: Pavel Machek <pavel@ucw.cz>
Cc: "Arnd Bergmann" <arnd@arndb.de>,
"Mauro Carvalho Chehab" <mchehab@kernel.org>,
"Sakari Ailus" <sakari.ailus@linux.intel.com>,
"Pali Rohár" <pali.rohar@gmail.com>,
linux-media@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] [media] ad5820: use __maybe_unused for PM functions
Date: Tue, 13 Sep 2016 11:31:46 +0300 [thread overview]
Message-ID: <20160913083146.GE5086@valkosipuli.retiisi.org.uk> (raw)
In-Reply-To: <20160912175207.GB8285@amd>
On Mon, Sep 12, 2016 at 07:52:08PM +0200, Pavel Machek wrote:
> On Mon 2016-09-12 17:32:57, Arnd Bergmann wrote:
> > The new ad5820 driver uses #ifdef to hide the suspend/resume functions,
> > but gets it wrong when CONFIG_PM_SLEEP is disabled:
> >
> > drivers/media/i2c/ad5820.c:286:12: error: 'ad5820_resume' defined but not used [-Werror=unused-function]
> > drivers/media/i2c/ad5820.c:274:12: error: 'ad5820_suspend' defined but not used [-Werror=unused-function]
> >
> > This replaces the #ifdef with a __maybe_unused annotation that is
> > simpler and harder to get wrong, avoiding the warning.
> >
> > Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> > Fixes: bee3d5115611 ("[media] ad5820: Add driver for auto-focus
> coil")
>
> Thanks!
>
> Acked-by: Pavel Machek <pavel@ucw.cz>
Thanks, Arnd and Pavel!
Added to my ad5820 branch.
--
Sakari Ailus
e-mail: sakari.ailus@iki.fi XMPP: sailus@retiisi.org.uk
prev parent reply other threads:[~2016-09-13 8:32 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-12 15:32 Arnd Bergmann
2016-09-12 15:32 ` [PATCH 2/2] [media] atmel-isc: mark PM functions as __maybe_unused Arnd Bergmann
2016-09-13 2:11 ` Wu, Songjun
2016-09-12 17:52 ` [PATCH 1/2] [media] ad5820: use __maybe_unused for PM functions Pavel Machek
2016-09-13 8:31 ` Sakari Ailus [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160913083146.GE5086@valkosipuli.retiisi.org.uk \
--to=sakari.ailus@iki.fi \
--cc=arnd@arndb.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=pali.rohar@gmail.com \
--cc=pavel@ucw.cz \
--cc=sakari.ailus@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®