From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1756601AbcIMIuP (ORCPT <rfc822;w@1wt.eu>);
        Tue, 13 Sep 2016 04:50:15 -0400
Received: from mail-pf0-f195.google.com ([209.85.192.195]:33832 "EHLO
        mail-pf0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1753712AbcIMIuL (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 13 Sep 2016 04:50:11 -0400
Date: Tue, 13 Sep 2016 16:50:05 +0800
From: Peter Chen <hzpeterchen@gmail.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Peter Chen <peter.chen@nxp.com>, Felipe Balbi <balbi@kernel.org>,
        Heikki Krogerus <heikki.krogerus@linux.intel.com>,
        linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] usb: Kconfig: make USB_ULPI_BUS select USB_COMMON
Message-ID: <20160913085005.GA30760@b29397-desktop>
References: <20160912153649.3163096-1-arnd@arndb.de>
 <2868310.g9cFv2gbYX@wuerfel>
 <20160913071942.GC30425@b29397-desktop>
 <21754633.f6gFxZW7VA@wuerfel>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <21754633.f6gFxZW7VA@wuerfel>
User-Agent: Mutt/1.5.24 (2015-08-30)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, Sep 13, 2016 at 09:36:39AM +0200, Arnd Bergmann wrote:
> On Tuesday, September 13, 2016 3:19:42 PM CEST Peter Chen wrote:
> > 
> > I just see below Kconfig entry at the same Kconfig
> > (drivers/usb/Kconfig), and forget your changes.
> > 
> > config USB_LED_TRIG
> >         bool "USB LED Triggers"
> >         depends on LEDS_CLASS && USB_COMMON && LEDS_TRIGGERS
> >         help
> >           This option adds LED triggers for USB host and/or gadget activity.
> > 
> >           Say Y here if you are working on a system with led-class supported
> >           LEDs and you want to use them as activity indicators for USB host or
> >           gadget.
> > 
> > Just grep it, some Kconfig still uses depends on for USB_COMMON, let me
> > change it together.
> > 
> 
> I suspect this one above should instead depend on "USB_SUPPORT".
> 

No, it is embraced by "if USB_SUPPORT", so we don't need to add it
additionally. Even USB_SUPPORT is chosen, the USB_COMMON may still
not be chosen, so we need let USB_LET_TRIG select USB_COMMON
explicitly.

-- 

Best Regards,
Peter Chen