From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1754617AbcIMDvZ (ORCPT <rfc822;w@1wt.eu>);
        Mon, 12 Sep 2016 23:51:25 -0400
Received: from mail-pa0-f50.google.com ([209.85.220.50]:34212 "EHLO
        mail-pa0-f50.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1750975AbcIMDvX (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 12 Sep 2016 23:51:23 -0400
Date: Tue, 13 Sep 2016 13:51:15 +1000
From: Nicholas Piggin <npiggin@gmail.com>
To: Guenter Roeck <linux@roeck-us.net>
Cc: Michal Marek <mmarek@suse.com>, Chen Liqin <liqin.linux@gmail.com>,
        Lennox Wu <lennox.wu@gmail.com>, linux-kernel@vger.kernel.org
Subject: Re: Build failure in -next due to 'kbuild: allow archs to select
 link dead code/data elimination'
Message-ID: <20160913135115.089a933b@roar.ozlabs.ibm.com>
In-Reply-To: <50a6953d-48c6-4577-2be9-03e6bd5b0706@roeck-us.net>
References: <20160912222443.GA8425@roeck-us.net>
        <20160913120014.1036bf91@roar.ozlabs.ibm.com>
        <50a6953d-48c6-4577-2be9-03e6bd5b0706@roeck-us.net>
Organization: IBM
X-Mailer: Claws Mail 3.14.0 (GTK+ 2.24.30; x86_64-pc-linux-gnu)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, 12 Sep 2016 20:17:30 -0700
Guenter Roeck <linux@roeck-us.net> wrote:

> Hi Nicholas,
> 
> On 09/12/2016 07:00 PM, Nicholas Piggin wrote:
> > On Mon, 12 Sep 2016 15:24:43 -0700
> > Guenter Roeck <linux@roeck-us.net> wrote:
> >  
> >> Hi,
> >>
> >> your commit 'kbuild: allow archs to select link dead code/data elimination'
> >> is causing the following build failure in -next when building score:defconfig.
> >>
> >> arch/score/kernel/built-in.o: In function `work_resched':
> >> arch/score/kernel/entry.o:(.text+0xe84):
> >> 	relocation truncated to fit: R_SCORE_PC19 against `schedule'
> >>
> >> Reverting the commit fixes the problem.
> >>
> >> Please let me know if I can help tracking down the problem.
> >> In case you need a score toochain, you can find the one I use at
> >> http://server.roeck-us.net/toolchains/score.tgz.
> >>
> >> Thanks,
> >> Guenter  
> >
> > It's not supposed to have any real effect unless the
> > option is selected, but there are a few changes to linker
> > script which must be causing it.
> >
> > There are two changes to vmlinux.lds.h. One is to KEEP a
> > few input sections, that *should* be kept anyway. The other
> > is to bring in additional sections into their correct output
> > section.
> >
> > Could you try reverting those lines of vmlinux.lds.h that
> > change the latter, i.e.:
> >
> > -		*(.text.hot .text .text.fixup .text.unlikely)		\
> > +		*(.text.hot .text .text.fixup .text.unlikely .text.*)	\  
> 
> This is the culprit. After removing " .text.*" it builds fine.

Thanks for testing it. Some architectures have .text.x sections
not included here, I should have seen that. We should possibly
just revert that line and require implementing archs to do the
right thing.

[ Convention is to use '.' to avoid C identifiers, so we should
use .text..x for these things. But that's not done completely
throughout the kernel, and a little invasive to do with this
series. I'll revisit this and clean things up subsequently after
this round gets merged. ]

Thanks,
Nick