From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1760253AbcIMTb7 (ORCPT <rfc822;w@1wt.eu>);
        Tue, 13 Sep 2016 15:31:59 -0400
Received: from emh02.mail.saunalahti.fi ([62.142.5.108]:36787 "EHLO
        emh02.mail.saunalahti.fi" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1760152AbcIMTb4 (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 13 Sep 2016 15:31:56 -0400
Date: Tue, 13 Sep 2016 22:31:54 +0300
From: Aaro Koskinen <aaro.koskinen@iki.fi>
To: =?iso-8859-1?Q?Asbj=F8rn_Sloth_T=F8nnesen?= <asbjorn@asbjorn.st>
Cc: Ralf Baechle <ralf@linux-mips.org>, linux-mips@linux-mips.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] MIPS: Octeon: Use defines instead of magic numbers
Message-ID: <20160913193154.GC1658@raspberrypi.musicnaut.iki.fi>
References: <20160912210314.GB1658@raspberrypi.musicnaut.iki.fi>
 <1473793494.15480.1@x201s.roaming.asbjorn.biz>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <1473793494.15480.1@x201s.roaming.asbjorn.biz>
User-Agent: Mutt/1.5.23 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi,

On Tue, Sep 13, 2016 at 07:04:54PM +0000, Asbjørn Sloth Tønnesen wrote:
> On Tue, 13 Sep 2016 00:03:14 +0300, Aaro Koskinen <aaro.koskinen@iki.fi> wrote:
> > On Mon, Sep 12, 2016 at 08:33:43PM +0000, Asbjoern Sloth Toennesen wrote:
> > > The patch will be followed by a similar patch to
> > > drivers/staging/octeon/ethernet.c
> > 
> > I think you should:
> > 
> > 	1. Move this function to staging/octeon
> > 
> > 	2. Do required cleanups there
> > 
> > 	3. Finally delete the function under arch/mips
> > 
> > We shouldn't start making cleanups (except code removal) to ethernet code
> > under mips/cavium-octeon/executive as it really does not belong there...
> 
> I agree that this would make sense, however I just came across this looking
> at the general MTU code across drivers, and don't have a real interest in
> this particular driver nor mips, so I am not looking to fall that deep into
> the rabbit hole.

In that case please leave the code alone. NAK for this patch.

A.