From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1761011AbcINSY7 (ORCPT ); Wed, 14 Sep 2016 14:24:59 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:40014 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932167AbcINSY4 (ORCPT ); Wed, 14 Sep 2016 14:24:56 -0400 DMARC-Filter: OpenDMARC Filter v1.3.1 smtp.codeaurora.org 51B0B61841 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=pass smtp.mailfrom=sboyd@codeaurora.org Date: Wed, 14 Sep 2016 11:24:54 -0700 From: Stephen Boyd To: arvind.yadav.cs@gmail.com Cc: mturquette@baylibre.com, a.hajda@samsung.com, lee.jones@linaro.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] clk: st: clk-flexgen: Unmap region obtained by of_iomap Message-ID: <20160914182454.GR7243@codeaurora.org> References: <57d92940.6329c80a.3d959.9d78@mx.google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <57d92940.6329c80a.3d959.9d78@mx.google.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 09/14, arvind.yadav.cs@gmail.com wrote: > @@ -337,6 +339,8 @@ static void __init st_of_flexgen_setup(struct device_node *np) > return; > > err: > + if (reg) This is always true? Why check? > + iounmap(reg); > if (clk_data) > kfree(clk_data->clks); > kfree(clk_data); > -- > 1.7.9.5 > -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project