From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933406AbcINUET (ORCPT ); Wed, 14 Sep 2016 16:04:19 -0400 Received: from bh-25.webhostbox.net ([208.91.199.152]:50774 "EHLO bh-25.webhostbox.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933041AbcINUEM (ORCPT ); Wed, 14 Sep 2016 16:04:12 -0400 Date: Wed, 14 Sep 2016 13:04:01 -0700 From: Guenter Roeck To: Mika Westerberg Cc: "Rafael J. Wysocki" , Len Brown , Jean Delvare , Wolfram Sang , Peter Tyser , Lee Jones , Zha Qipeng , Darren Hart , Wim Van Sebroeck , linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 3/4] i2c: i801: Do not create iTCO watchdog when WDAT table exists Message-ID: <20160914200401.GB14003@roeck-us.net> References: <20160913152336.75405-1-mika.westerberg@linux.intel.com> <20160913152336.75405-4-mika.westerberg@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160913152336.75405-4-mika.westerberg@linux.intel.com> User-Agent: Mutt/1.5.23 (2014-03-12) X-Authenticated_sender: guenter@roeck-us.net X-OutGoing-Spam-Status: No, score=-1.0 X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - bh-25.webhostbox.net X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - roeck-us.net X-Get-Message-Sender-Via: bh-25.webhostbox.net: authenticated_id: guenter@roeck-us.net X-Authenticated-Sender: bh-25.webhostbox.net: guenter@roeck-us.net X-Source: X-Source-Args: X-Source-Dir: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Sep 13, 2016 at 06:23:35PM +0300, Mika Westerberg wrote: > ACPI WDAT table is the preferred way to use hardware watchdog over the > native iTCO_wdt. Windows only uses this table for its hardware watchdog > implementation so we should be relatively safe to trust it has been > validated by OEMs > > Prevent iTCO watchdog creation if we detect that there is ACPI WDAT table. > > Signed-off-by: Mika Westerberg Reviewed-by: Guenter Roeck > --- > drivers/i2c/busses/i2c-i801.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/i2c/busses/i2c-i801.c b/drivers/i2c/busses/i2c-i801.c > index 5ef9b733d153..26298af73232 100644 > --- a/drivers/i2c/busses/i2c-i801.c > +++ b/drivers/i2c/busses/i2c-i801.c > @@ -1486,7 +1486,9 @@ static int i801_probe(struct pci_dev *dev, const struct pci_device_id *id) > priv->features |= FEATURE_IRQ; > priv->features |= FEATURE_SMBUS_PEC; > priv->features |= FEATURE_BLOCK_BUFFER; > - priv->features |= FEATURE_TCO; > + /* If we have ACPI based watchdog use that instead */ > + if (!acpi_has_watchdog()) > + priv->features |= FEATURE_TCO; > priv->features |= FEATURE_HOST_NOTIFY; > break; > > -- > 2.9.3 >