From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934034AbcIONhI (ORCPT ); Thu, 15 Sep 2016 09:37:08 -0400 Received: from mail-oi0-f67.google.com ([209.85.218.67]:35897 "EHLO mail-oi0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756963AbcIONg7 (ORCPT ); Thu, 15 Sep 2016 09:36:59 -0400 Date: Thu, 15 Sep 2016 08:36:57 -0500 From: Rob Herring To: Robin Murphy Cc: frowand.list@gmail.com, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, lorenzo.pieralisi@arm.com, okaya@codeaurora.org, yisen.zhuang@huawei.com, salil.mehta@huawei.com Subject: Re: [PATCH] of/platform: Initialise dev->fwnode appropriately Message-ID: <20160915133657.GB14424@rob-hp-laptop> References: <38259ab3716da072fab37f06d034329244491c13.1473865096.git.robin.murphy@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <38259ab3716da072fab37f06d034329244491c13.1473865096.git.robin.murphy@arm.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Sep 14, 2016 at 04:01:24PM +0100, Robin Murphy wrote: > Whilst we're some of the way towards a universal firmware property > interface, drivers which deal with both OF and ACPI probing end up > having to do things like this: > > dev->of_node ? &dev->of_node->fwnode : dev->fwnode > > This seems unnecessary, when the OF code could instead simply fill in > the device's fwnode when binding the of_node, and let the drivers use > dev->fwnode either way. Let's give it a go and see what falls out. > > Signed-off-by: Robin Murphy > --- > drivers/of/platform.c | 2 ++ > 1 file changed, 2 insertions(+) I've applied this, but what about non-platform devices such as i2c? Rob