From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752823AbcIOOwm (ORCPT ); Thu, 15 Sep 2016 10:52:42 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:58017 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751021AbcIOOwg (ORCPT ); Thu, 15 Sep 2016 10:52:36 -0400 Date: Thu, 15 Sep 2016 16:52:38 +0200 From: Greg KH To: Baoyou Xie Cc: oleg.drokin@intel.com, andreas.dilger@intel.com, jsimmons@infradead.org, john.hammond@intel.com, shraddha.6596@gmail.com, di.wang@intel.com, ksenija.stanojevic@gmail.com, mike.rapoport@gmail.com, andrew.perepechko@seagate.com, kirill.shutemov@linux.intel.com, lustre-devel@lists.lustre.org, devel@driverdev.osuosl.org, xie.baoyou@zte.com.cn, linux-kernel@vger.kernel.org, arnd@arndb.de Subject: Re: [PATCH] staging: lustre: clean function declarations in class_obd.c up Message-ID: <20160915145238.GB26016@kroah.com> References: <1473947487-25514-1-git-send-email-baoyou.xie@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1473947487-25514-1-git-send-email-baoyou.xie@linaro.org> User-Agent: Mutt/1.7.0 (2016-08-17) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Sep 15, 2016 at 09:51:27PM +0800, Baoyou Xie wrote: > We get 2 warnings when building kernel with W=1: Don't do that! :) > > drivers/staging/lustre/lustre/obdclass/linux/linux-module.c:413:5: warning: no previous prototype for 'class_procfs_init' [-Wmissing-prototypes] > drivers/staging/lustre/lustre/obdclass/linux/linux-module.c:449:5: warning: no previous prototype for 'class_procfs_clean' [-Wmissing-prototypes] > > In fact, both functions are declared in > drivers/staging/lustre/lustre/obdclass/class_obd.c,but should be > declared in a header file, thus can be recognized in other file. > > So this patch moves the declarations into > drivers/staging/lustre/lustre/include/obd_class.h. > > Signed-off-by: Baoyou Xie > --- > drivers/staging/lustre/lustre/include/obd_class.h | 4 ++++ > drivers/staging/lustre/lustre/obdclass/class_obd.c | 2 -- > 2 files changed, 4 insertions(+), 2 deletions(-) > > diff --git a/drivers/staging/lustre/lustre/include/obd_class.h b/drivers/staging/lustre/lustre/include/obd_class.h > index 9702ad4..9965a01 100644 > --- a/drivers/staging/lustre/lustre/include/obd_class.h > +++ b/drivers/staging/lustre/lustre/include/obd_class.h > @@ -1712,6 +1712,10 @@ int class_check_uuid(struct obd_uuid *uuid, __u64 nid); > void class_init_uuidlist(void); > void class_exit_uuidlist(void); > > +/*linux-module.c*/ Here, have a ' '. make that two... thanks, greg k-h