From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754556AbcIOPnr (ORCPT ); Thu, 15 Sep 2016 11:43:47 -0400 Received: from imap.thunk.org ([74.207.234.97]:55776 "EHLO imap.thunk.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751861AbcIOPni (ORCPT ); Thu, 15 Sep 2016 11:43:38 -0400 Date: Thu, 15 Sep 2016 11:43:16 -0400 From: "Theodore Ts'o" To: Fabian Frederick Cc: Andreas Dilger , linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/6 linux-next] ext4: avoid EXT4_INODE_EXTENTS double checking Message-ID: <20160915154316.okll4lnjq2gqstgk@thunk.org> Mail-Followup-To: Theodore Ts'o , Fabian Frederick , Andreas Dilger , linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org References: <1472069000-18897-1-git-send-email-fabf@skynet.be> <1472069000-18897-2-git-send-email-fabf@skynet.be> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1472069000-18897-2-git-send-email-fabf@skynet.be> User-Agent: NeoMutt/ (1.7.0) X-SA-Exim-Connect-IP: X-SA-Exim-Mail-From: tytso@thunk.org X-SA-Exim-Scanned: No (on imap.thunk.org); SAEximRunCond expanded to false Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Aug 24, 2016 at 10:03:15PM +0200, Fabian Frederick wrote: > ext4_collapse_range() and ext4_insert_range() > already checked inode flag at the beginning of function. > > Signed-off-by: Fabian Frederick Actually, these checks are required since the check at the beginning are done before taking the inode lock. One could argue that we should get rid of the first check, since we don't need to optimize for the error case. But removing the second check is definitely wrong. Cheers, - Ted