From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754538AbcIOP6b (ORCPT ); Thu, 15 Sep 2016 11:58:31 -0400 Received: from mout.kundenserver.de ([212.227.126.130]:54181 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752074AbcIOP6Y (ORCPT ); Thu, 15 Sep 2016 11:58:24 -0400 From: Arnd Bergmann To: Laura Abbott , Sumit Semwal Cc: Arnd Bergmann , Greg Kroah-Hartman , =?UTF-8?q?Arve=20Hj=C3=B8nnev=C3=A5g?= , Riley Andrews , Chen Feng , devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: [PATCH] staging: android ion/hisi: fix dependencies Date: Thu, 15 Sep 2016 17:57:40 +0200 Message-Id: <20160915155751.3011135-1-arnd@arndb.de> X-Mailer: git-send-email 2.9.0 X-Provags-ID: V03:K0:ao7vJx1KoaC4Wq/p76SPwJlkj2PRXidjEMktvk3iFx5h7bTHmOc b3hMJKtY1ZTzfMd/Hozc6YKbDlSqlbHaz6xgzwRbPtwgUhMDwlQee1NxDpVZFH47K8INw3E hK6haEHFfLcL8383ug0JYUECJ5ZYVc/QVyqEf1ZiEQES6T62gE5l26xp1nLhyjkR7PgxNVF YbdhSGNlMoI9Wx3nyuocw== X-UI-Out-Filterresults: notjunk:1;V01:K0:JG0WLTsK+Fg=:libct2KbbFR1H8QZ7386YQ 42Gn0v6wcaDY0O9VAk5wpA81eLAEvMI+AZR576wmiUKkT132sPNeTnpGUhOrngzDdNCf/rdor HJmOGQzRoSrY1rnYhaDLz7Sp7fkPz0+vQGqNeWMENbuMZnG63TEdup6DtOPwdI5tvi2bwaNIy PuPmocEre6OxozllFJ2DZiNuWIBQR8U/2rDlIqKpoNJUMriP1N9YdV0eJvjP43HUT1Eg01Psi 9/MiBuS0sWV/nKhpr61bXZpevLsrE2we9Vkos+tyA1v8oTz+q0/VDCHQBXgy5izlzlsJ7lx1y 1izWkfP/bWMuGAEq4Lf1KWdY5SPkh1mRa5E6UOWOpgP8cfwvpKVTVh3WMx9tcK7wMLYR3H5Tj C3XrJbiurOyL4vopLRjPZCLP5rjlheMZ3RK+J8x4oQXlKall9rZkh3X3pezu/gh4GSXmGaEdQ jT/KL/5p3FctfhcpVTNquExWqOtC9WNW+rmn+pU/IfcsJE692EkAcs6sgv+TsW19pGPhSppBC 8jCOwPTOvaDXcWdWk07pF81jn3F4rhsqXP3PZIL7Ey8KiTpOWbmS4oFcfFWcdQc2V+4qEYKNf jhXev+Ksi55KIUXzntRGN3EeXPZ5XsZD8RT+FJr1+5OlRoqUpJG+sKk2DI+O3ZbVr/td+Rw+N HSWMX7tenhUNKNT0Zo268kyOMD9gqSreZ5vk+vS6VCZGQAtsVmPcGAk0mPXcsZ80j1ig= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The newly added Hi6220 Ion code fails to build when the ION_OF helpers are not present: drivers/staging/android/ion/hisilicon/hi6220_ion.o: In function `hi6220_ion_remove': hi6220_ion.c:(.text.hi6220_ion_remove+0x4c): undefined reference to `ion_destroy_platform_data' drivers/staging/android/ion/hisilicon/hi6220_ion.o: In function `hi6220_ion_probe': hi6220_ion.c:(.text.hi6220_ion_probe+0x5c): undefined reference to `ion_parse_dt' hi6220_ion.c:(.text.hi6220_ion_probe+0xf8): undefined reference to `ion_destroy_platform_data' This selects the symbol when needed. Signed-off-by: Arnd Bergmann Fixes: 2b40182a19bc ("staging: android: ion: Add ion driver for Hi6220 SoC platform") --- drivers/staging/android/ion/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/staging/android/ion/Kconfig b/drivers/staging/android/ion/Kconfig index 94105544feef..c8fb4134c55d 100644 --- a/drivers/staging/android/ion/Kconfig +++ b/drivers/staging/android/ion/Kconfig @@ -36,6 +36,7 @@ config ION_TEGRA config ION_HISI tristate "Ion for Hisilicon" depends on ARCH_HISI && ION + select ION_OF help Choose this option if you wish to use ion on Hisilicon Platform. -- 2.9.0