From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752497AbcIOQD7 (ORCPT ); Thu, 15 Sep 2016 12:03:59 -0400 Received: from imap.thunk.org ([74.207.234.97]:55948 "EHLO imap.thunk.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751085AbcIOQD5 (ORCPT ); Thu, 15 Sep 2016 12:03:57 -0400 Date: Thu, 15 Sep 2016 12:03:09 -0400 From: "Theodore Ts'o" To: Jan Kara Cc: Geliang Tang , Jan Kara , Eric Ren , linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] jbd2: move more common code into journal_init_common() Message-ID: <20160915160309.okkvwpxz4im5abti@thunk.org> Mail-Followup-To: Theodore Ts'o , Jan Kara , Geliang Tang , Jan Kara , Eric Ren , linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org References: <50f2f9e8f6e503a3bd9a54b4dcb58531e18dbf52.1473240936.git.geliangtang@gmail.com> <20160907131624.GU28922@quack2.suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160907131624.GU28922@quack2.suse.cz> User-Agent: NeoMutt/ (1.7.0) X-SA-Exim-Connect-IP: X-SA-Exim-Mail-From: tytso@thunk.org X-SA-Exim-Scanned: No (on imap.thunk.org); SAEximRunCond expanded to false Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Sep 07, 2016 at 03:16:24PM +0200, Jan Kara wrote: > On Wed 07-09-16 20:41:13, Geliang Tang wrote: > > There are some repetitive code in jbd2_journal_init_dev() and > > jbd2_journal_init_inode(). So this patch moves the common code into > > journal_init_common() helper to simplify the code. And fix the coding > > style warnings reported by checkpatch.pl by the way. > > > > Signed-off-by: Geliang Tang > > The patch looks good to me. You can add: > > Reviewed-by: Jan Kara Applied, thanks. - Ted