From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752974AbcIOQW7 (ORCPT ); Thu, 15 Sep 2016 12:22:59 -0400 Received: from userp1040.oracle.com ([156.151.31.81]:21973 "EHLO userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751783AbcIOQWv (ORCPT ); Thu, 15 Sep 2016 12:22:51 -0400 From: Phil Turnbull To: linux-kernel@vger.kernel.org Cc: Christoph Hellwig , Joel Becker , Phil Turnbull Subject: [PATCH] configfs: Return -EFBIG from configfs_write_bin_file. Date: Thu, 15 Sep 2016 12:20:12 -0400 Message-Id: <20160915162012.21014-1-phil.turnbull@oracle.com> X-Mailer: git-send-email 2.9.0.rc2 X-Source-IP: userv0022.oracle.com [156.151.31.74] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The check for writing more than cb_max_size bytes does not 'goto out' so it is a no-op which allows users to vmalloc an arbitrary amount. Fixes: 03607ace807b ("configfs: implement binary attributes") Signed-off-by: Phil Turnbull --- fs/configfs/file.c | 1 + 1 file changed, 1 insertion(+) diff --git a/fs/configfs/file.c b/fs/configfs/file.c index c30cf49b69d2..2c6312db8516 100644 --- a/fs/configfs/file.c +++ b/fs/configfs/file.c @@ -333,6 +333,7 @@ configfs_write_bin_file(struct file *file, const char __user *buf, if (bin_attr->cb_max_size && *ppos + count > bin_attr->cb_max_size) { len = -EFBIG; + goto out; } tbuf = vmalloc(*ppos + count); -- 2.9.0.rc2