From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752399AbcIORoF (ORCPT ); Thu, 15 Sep 2016 13:44:05 -0400 Received: from merlin.infradead.org ([205.233.59.134]:52814 "EHLO merlin.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751263AbcIORn6 (ORCPT ); Thu, 15 Sep 2016 13:43:58 -0400 Date: Thu, 15 Sep 2016 19:43:46 +0200 From: Peter Zijlstra To: "Brown, Len" Cc: Prarit Bhargava , "linux-kernel@vger.kernel.org" , Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , "x86@kernel.org" , Rafael Aquini , Andy Lutomirski , "lenb@kernel.org" Subject: Re: [PATCH 2/2] x86/tsc: Add additional Intel CPU models to crystal_khz whitelist Message-ID: <20160915174346.GH5012@twins.programming.kicks-ass.net> References: <1473951858-28921-1-git-send-email-prarit@redhat.com> <1473951858-28921-3-git-send-email-prarit@redhat.com> <1A7043D5F58CCB44A599DFD55ED4C94846AE889E@fmsmsx115.amr.corp.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1A7043D5F58CCB44A599DFD55ED4C94846AE889E@fmsmsx115.amr.corp.intel.com> User-Agent: Mutt/1.5.23.1 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Sep 15, 2016 at 04:08:36PM +0000, Brown, Len wrote: > > + crystal_khz = 24000; /* 25.0 MHz */ > > I guess I prefer no comment over an incorrect comment. > >>From this I take it it should really have been 24 MHz and it could have joined the existing case. I assumed (ha!) that since it had a special separate case the comment was correct.