From: Jan Kara <jack@suse.cz>
To: Guenter Roeck <linux@roeck-us.net>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Jan Kara <jack@suse.cz>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: Crashes in next-20160915 (BUG at fs/notify/notification.c:66!)
Date: Fri, 16 Sep 2016 08:45:21 +0200 [thread overview]
Message-ID: <20160916064521.GF24269@quack2.suse.cz> (raw)
In-Reply-To: <fe340e8d-f77b-bb4b-8c39-d3d52b0a9b1a@roeck-us.net>
Hi,
On Thu 15-09-16 19:20:10, Guenter Roeck wrote:
> I see various architectures crashing in -next with the following error.
>
> ------------[ cut here ]------------
> kernel BUG at fs/notify/notification.c:66!
Thanks for report!
...
> Call Trace:
> [<ffffffff811bd532>] inotify_poll+0x42/0x70
> [<ffffffff811bfeba>] SyS_epoll_ctl+0x84a/0xf60
> [<ffffffff811be4a0>] ? ep_send_events_proc+0x180/0x180
> [<ffffffff8176be98>] entry_SYSCALL_64_fastpath+0x13/0x8f
> Code: 90 90 0f 1f 44 00 00 55 b8 01 00 00 00 48 89 e5 0f c1 05 bb e4 d4 00 83 c0 01 5d c3 66 0f 1f 44 00 00 0f 1f 44 00 00 55 48 89 e5 <0f> 0b 0f 1f 44 00 00 0f 1f 44 00 00 55 48 89 e5 48 83 ec 10 48
> RIP [<ffffffff811bb399>] fsnotify_notify_queue_is_empty+0x9/0x10
> RSP <ffffc90000253e68>
> ---[ end trace 7dc4a27003f0b575 ]---
>
> I didn't bisect, but I would guess the culprit is one of the new patches in the
> affected file.
>
> 22e9cf146d3b fanotify: fix possible false warning when freeing events
> ced89591817c fsnotify: convert notification_mutex to a spinlock
> f82fa3d0e7f5 fsnotify: drop notification_mutex before destroying event
> 782fbc7e8685 fanotify: fix list corruption in fanotify_get_response()
> 56cf1c8a1b35 fsnotify: add a way to stop queueing events on group shutdown
Yes, very likely my patches cause this. But it must be some config issue
because my test machine does not hit this and the code is "obviously
correct" - famous last words ;). I've seen zero-day robot complain as well
so I'll try the config it had sent me and see what's going on (likely
spin_is_locked() does not do what I thought under some configs...).
Honza
--
Jan Kara <jack@suse.com>
SUSE Labs, CR
next prev parent reply other threads:[~2016-09-16 9:12 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-16 2:20 Guenter Roeck
2016-09-16 6:45 ` Jan Kara [this message]
2016-09-16 11:10 ` Guenter Roeck
2016-09-16 12:49 ` Jan Kara
2016-09-20 1:10 ` Michael Ellerman
2016-09-20 1:13 ` Andrew Morton
2016-09-20 12:05 ` Michael Ellerman
2016-09-21 9:15 ` Jan Kara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160916064521.GF24269@quack2.suse.cz \
--to=jack@suse.cz \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®