From: Christoph Hellwig <hch@lst.de>
To: Andy Lutomirski <luto@kernel.org>
Cc: Keith Busch <keith.busch@intel.com>, Jens Axboe <axboe@fb.com>,
linux-nvme@lists.infradead.org, Christoph Hellwig <hch@lst.de>,
linux-kernel@vger.kernel.org,
J Freyensee <james_p_freyensee@linux.intel.com>
Subject: Re: [PATCH v3 1/3] nvme/scsi: Remove power management support
Date: Fri, 16 Sep 2016 10:33:33 +0200 [thread overview]
Message-ID: <20160916083333.GB2415@lst.de> (raw)
In-Reply-To: <714df91022b06c6799afb315962769f22b8ab9f4.1474002926.git.luto@kernel.org>
On Thu, Sep 15, 2016 at 10:24:19PM -0700, Andy Lutomirski wrote:
> As far as I can tell, there is basically nothing correct about this
> code. It misinterprets npss (off-by-one). It hardcodes a bunch of
> power states, which is nonsense, because they're all just indices
> into a table that software needs to parse. It completely ignores
> the distinction between operational and non-operational states.
> And, until 4.8, if all of the above magically succeeded, it would
> dereference a NULL pointer and OOPS.
>
> Since this code appears to be useless, just delete it.
Yes, please!
Acked-by: Christoph Hellwig <hch@lst.de>
next prev parent reply other threads:[~2016-09-16 8:33 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-16 5:24 [PATCH v3 0/3] nvme power saving Andy Lutomirski
2016-09-16 5:24 ` [PATCH v3 1/3] nvme/scsi: Remove power management support Andy Lutomirski
2016-09-16 8:33 ` Christoph Hellwig [this message]
2016-09-16 14:33 ` Keith Busch
2016-09-16 14:25 ` Christoph Hellwig
2016-09-19 7:59 ` Johannes Thumshirn
2016-09-16 23:33 ` J Freyensee
2016-09-16 5:24 ` [PATCH v3 2/3] nvme: Pass pointers, not dma addresses, to nvme_get/set_features() Andy Lutomirski
2016-09-16 8:41 ` Christoph Hellwig
2016-09-16 15:13 ` Andy Lutomirski
2016-09-16 15:34 ` Jens Axboe
2016-09-16 5:24 ` [PATCH v3 3/3] nvme: Enable autonomous power state transitions Andy Lutomirski
2016-09-16 8:42 ` Christoph Hellwig
2016-09-16 15:14 ` Andy Lutomirski
2016-09-16 16:51 ` Christoph Hellwig
2016-09-16 15:38 ` Keith Busch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160916083333.GB2415@lst.de \
--to=hch@lst.de \
--cc=axboe@fb.com \
--cc=james_p_freyensee@linux.intel.com \
--cc=keith.busch@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=luto@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome