From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757531AbcIPJcg (ORCPT ); Fri, 16 Sep 2016 05:32:36 -0400 Received: from mailapp01.imgtec.com ([195.59.15.196]:37057 "EHLO mailapp01.imgtec.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752123AbcIPJc2 (ORCPT ); Fri, 16 Sep 2016 05:32:28 -0400 From: Eric Engestrom To: CC: Eric Engestrom , Jeff Moyer , Jens Axboe , Johannes Thumshirn , Dan Williams , Ming Lin , Mike Christie Subject: [PATCH v2] skd: fix assert typo Date: Fri, 16 Sep 2016 10:31:23 +0100 Message-ID: <20160916093125.14322-1-eric.engestrom@imgtec.com> X-Mailer: git-send-email 2.9.3 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [10.60.4.28] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The assert was missing a `!` to become active, but since that would only turn it into a complicated codepath for a pr_err(), let's simply replace it. CC: Jeff Moyer Signed-off-by: Eric Engestrom --- drivers/block/skd_main.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/block/skd_main.c b/drivers/block/skd_main.c index 3822eae..c04e92a 100644 --- a/drivers/block/skd_main.c +++ b/drivers/block/skd_main.c @@ -1905,7 +1905,7 @@ static void skd_send_internal_skspcl(struct skd_device *skdev, break; default: - SKD_ASSERT("Don't know what to send"); + pr_err("Don't know what to send"); return; } @@ -2105,7 +2105,7 @@ static void skd_complete_internal(struct skd_device *skdev, break; default: - SKD_ASSERT("we didn't send this"); + pr_err("we didn't send this"); } } -- Cheers, Eric