From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934691AbcIPMAF (ORCPT ); Fri, 16 Sep 2016 08:00:05 -0400 Received: from mx2.suse.de ([195.135.220.15]:39084 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934502AbcIPL7o (ORCPT ); Fri, 16 Sep 2016 07:59:44 -0400 Date: Fri, 16 Sep 2016 13:59:30 +0200 From: Johannes Thumshirn To: Eric Engestrom Cc: linux-kernel@vger.kernel.org, Jeff Moyer , Jens Axboe , Dan Williams , Ming Lin , Mike Christie Subject: Re: [PATCH v2] skd: fix assert typo Message-ID: <20160916115930.ydfcgohliglkricg@linux-x5ow.site> References: <20160916093125.14322-1-eric.engestrom@imgtec.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20160916093125.14322-1-eric.engestrom@imgtec.com> User-Agent: Mutt/1.6.2-neo (2016-06-11) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Sep 16, 2016 at 10:31:23AM +0100, Eric Engestrom wrote: > The assert was missing a `!` to become active, but since that would only turn > it into a complicated codepath for a pr_err(), let's simply replace it. > > CC: Jeff Moyer > Signed-off-by: Eric Engestrom > --- Looks ok, Reviewed-by: Johannes Thumshirn -- Johannes Thumshirn Storage jthumshirn@suse.de +49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg) Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850