From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S935199AbcIPM2w (ORCPT ); Fri, 16 Sep 2016 08:28:52 -0400 Received: from mail-oi0-f66.google.com ([209.85.218.66]:34894 "EHLO mail-oi0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934799AbcIPM2m (ORCPT ); Fri, 16 Sep 2016 08:28:42 -0400 Date: Fri, 16 Sep 2016 07:28:40 -0500 From: Rob Herring To: Matthias Kaehlcke Cc: Mark Brown , lgirdwood@gmail.com, Douglas Anderson , briannorris@chromium.org, javier@dowhile0.org, mark.rutland@arm.com, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org Subject: Re: [PATCH v4 3/4] regulator: Add support for a fixed delay after voltage increases Message-ID: <20160916122840.GA3388@rob-hp-laptop> References: <20160906190504.GA79728@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160906190504.GA79728@google.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Sep 06, 2016 at 12:05:04PM -0700, Matthias Kaehlcke wrote: > The target voltage isn't necessarily reached inmediately after > requesting a regulator to change the voltage. In some cases the > ramp_delay can be used to calculate the stabilisation time, in others > there is no direct relationship between the delta in the voltage and > the stabilisation time. This change introduces the device tree property > "regulator-settle-time-up-us" which allows to specify a fixed delay > after a voltage increase. > > We don't add an option of a fixed delay on the way down for now because > the way down is probably modelled best with a ramp rate, not a fixed > delay. > > Signed-off-by: Matthias Kaehlcke > Signed-off-by: Douglas Anderson > > --- > Changes in v4: > - Moved from PWM regulator to regulator core > - Added 'regulator' prefix to device tree property > > .../devicetree/bindings/regulator/regulator.txt | 2 ++ > drivers/regulator/core.c | 24 +++++++++++++--------- > drivers/regulator/of_regulator.c | 4 ++++ > include/linux/regulator/machine.h | 2 ++ > 4 files changed, 22 insertions(+), 10 deletions(-) Acked-by: Rob Herring