From: Greg KH <gregkh@linuxfoundation.org>
To: zerons <sironhide0null@gmail.com>
Cc: liodot@gmail.com, charrer@alacritech.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 01/10] staging: slicoss: slic.h: add a macro IOMEM_GET_FIELDADDR to fix sparse warnings
Date: Fri, 16 Sep 2016 14:57:27 +0200 [thread overview]
Message-ID: <20160916125727.GC29701@kroah.com> (raw)
In-Reply-To: <157cd71a-bce4-03f3-bc76-635f493c0051@gmail.com>
A: Because it messes up the order in which people normally read text.
Q: Why is top-posting such a bad thing?
A: Top-posting.
Q: What is the most annoying thing in e-mail?
A: No.
Q: Should I include quotations after my reply?
http://daringfireball.net/2007/07/on_top
On Fri, Sep 16, 2016 at 06:41:38PM +0800, zerons wrote:
> these marcos are used to get the value or address of a member of a `__iomem` structure.
> GET_FIELDADDR is like &iomem_obj->field, and
> GET_FIELD32 is iomem_obj->u32val, GET_FIELD64 is iomem_obj->u64val.
>
> If patch the .c file directly, the source gets into a mess.
But add the macro, and then use it, in the same patch, so we can verify
that this macro really is doing what you think it is doing, and so that
it is used at the same time (no need to add a macro that no one uses...
thanks,
greg k-h
next prev parent reply other threads:[~2016-09-16 12:57 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-14 2:59 [PATCH 00/10] staging: slicoss: fix different address space " Peng Sun
2016-09-14 2:59 ` [PATCH 01/10] staging: slicoss: slic.h: add a macro IOMEM_GET_FIELDADDR to fix " Peng Sun
2016-09-14 2:59 ` [PATCH 02/10] staging: slicoss: slic.h: add a macro IOMEM_GET_FIELD32 " Peng Sun
2016-09-14 2:59 ` [PATCH 03/10] staging: slicoss: slic.h: add a macro IOMEM_SET_FIELD32 " Peng Sun
2016-09-14 2:59 ` [PATCH 04/10] staging: slicoss: slic.h: add a macro IOMEM_GET_FIELD64 " Peng Sun
2016-09-14 2:59 ` [PATCH 05/10] staging: slicoss: slicoss.c: fix different address space sparse warning Peng Sun
2016-09-14 2:59 ` [PATCH 06/10] " Peng Sun
2016-09-14 2:59 ` [PATCH 07/10] " Peng Sun
2016-09-14 2:59 ` [PATCH 08/10] " Peng Sun
2016-09-14 2:59 ` [PATCH 09/10] " Peng Sun
2016-09-14 2:59 ` [PATCH 10/10] " Peng Sun
2016-09-16 7:52 ` [PATCH 01/10] staging: slicoss: slic.h: add a macro IOMEM_GET_FIELDADDR to fix sparse warnings Greg KH
2016-09-16 7:52 ` Greg KH
2016-09-16 10:41 ` zerons
2016-09-16 12:57 ` Greg KH [this message]
2016-09-16 13:54 ` zerons
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160916125727.GC29701@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=charrer@alacritech.com \
--cc=linux-kernel@vger.kernel.org \
--cc=liodot@gmail.com \
--cc=sironhide0null@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome