From: Kim Phillips <kim.phillips@arm.com>
To: "Naveen N. Rao" <naveen.n.rao@linux.vnet.ibm.com>
Cc: Wang Nan <wangnan0@huawei.com>, <acme@kernel.org>,
<linux-kernel@vger.kernel.org>, <lizefan@huawei.com>,
<pi3orama@163.com>, Arnaldo Carvalho de Melo <acme@redhat.com>
Subject: Re: [PATCH 2/2] tools include: Add mman macros needed by perf for all arch
Date: Fri, 16 Sep 2016 18:17:22 -0500 [thread overview]
Message-ID: <20160916181722.6133eb75367ac986622e2038@arm.com> (raw)
In-Reply-To: <20160914114606.GD21691@naverao1-tp.localdomain>
On Wed, 14 Sep 2016 17:16:06 +0530
"Naveen N. Rao" <naveen.n.rao@linux.vnet.ibm.com> wrote:
> On 2016/09/14 10:57AM, Wang Nan wrote:
> > Some macros required by tools/perf/trace/beauty/mmap.c is not support
> > for all architectures. For example, MAP_32BIT is defined on x86 only,
> > alpha doesn't define MADV_HWPOISON and MADV_SOFT_OFFLINE.
> >
> > This patch regenerates mman.h for each archs, defines these missing
> > macros for perf. For missing MADV_*, fall back to asm-generic/mman-common
> > because they are in 'case ...' statement. For flags, define to 0.
>
> This resolves the build issue on powerpc, thanks!
ditto for arm
> Tested-by: Naveen N. Rao <naveen.n.rao@linux.vnet.ibm.com>
Tested-by: Kim Phillips <kim.phillips@arm.com>
Thanks,
Kim
next prev parent reply other threads:[~2016-09-16 23:17 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-14 10:57 [PATCH 0/2] tools include: Fix uapi mman.h for each architecture Wang Nan
2016-09-14 10:57 ` [PATCH 1/2] perf trace beauty mmap: Add missing MADV_FREE Wang Nan
2016-09-20 21:42 ` [tip:perf/core] " tip-bot for Wang Nan
2016-09-14 10:57 ` [PATCH 2/2] tools include: Add mman macros needed by perf for all arch Wang Nan
2016-09-14 11:46 ` Naveen N. Rao
2016-09-16 23:17 ` Kim Phillips [this message]
2016-09-19 14:32 ` Arnaldo Carvalho de Melo
2016-09-20 21:42 ` [tip:perf/core] " tip-bot for Wang Nan
2016-09-16 12:41 ` [PATCH 0/2] tools include: Fix uapi mman.h for each architecture Ravi Bangoria
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160916181722.6133eb75367ac986622e2038@arm.com \
--to=kim.phillips@arm.com \
--cc=acme@kernel.org \
--cc=acme@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lizefan@huawei.com \
--cc=naveen.n.rao@linux.vnet.ibm.com \
--cc=pi3orama@163.com \
--cc=wangnan0@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®