From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754233AbcIQSpp (ORCPT ); Sat, 17 Sep 2016 14:45:45 -0400 Received: from mx1.redhat.com ([209.132.183.28]:52300 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753271AbcIQSph (ORCPT ); Sat, 17 Sep 2016 14:45:37 -0400 Date: Sat, 17 Sep 2016 13:45:34 -0500 From: Josh Poimboeuf To: Linus Torvalds Cc: Peter Zijlstra , Stephane Eranian , Vince Weaver , LKML , Alexander Shishkin , Ingo Molnar , Kees Cook Subject: Re: [PATCH v2] scripts: add script for translating stack dump function offsets Message-ID: <20160917184534.trb3jzzur7iipmr7@treble> References: <20160915072425.GN5008@twins.programming.kicks-ass.net> <20160915121014.ox5ytlplt7wz5cpk@treble> <20160916144807.6yrdznupo3bpe5b2@treble> <20160916191738.v3kq3c44zmdsvlgb@treble> <20160916212656.bnmxrl3cglsbjmpm@treble> <20160917004212.tsr3taygbcidvgl5@treble> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.6.0.1 (2016-04-01) X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.29]); Sat, 17 Sep 2016 18:45:36 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Sep 16, 2016 at 06:59:22PM -0700, Linus Torvalds wrote: > On Fri, Sep 16, 2016 at 5:42 PM, Josh Poimboeuf wrote: > > On Fri, Sep 16, 2016 at 05:09:15PM -0700, Linus Torvalds wrote: > >> On Fri, Sep 16, 2016 at 2:26 PM, Josh Poimboeuf wrote: > >> > > >> > Ok, how about this. If this looks ok, would you be willing to apply it? > >> > >> Looks good to me. Did you test the size verification with some made-up cases? > > > > Yep. And I tested all the other edge cases that occurred to me. > > Hmm. So I tested it a bit, and I found a few issues.. Ok, I agree with pretty much everything you said. I'll try to add those improvements next week. -- Josh