From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1754304AbcIQSso (ORCPT <rfc822;w@1wt.eu>);
        Sat, 17 Sep 2016 14:48:44 -0400
Received: from mx1.redhat.com ([209.132.183.28]:52694 "EHLO mx1.redhat.com"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1753793AbcIQSsf (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Sat, 17 Sep 2016 14:48:35 -0400
Date: Sat, 17 Sep 2016 13:48:33 -0500
From: Josh Poimboeuf <jpoimboe@redhat.com>
To: Rabin Vincent <rabin@rab.in>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
        Peter Zijlstra <peterz@infradead.org>,
        Stephane Eranian <eranian@google.com>,
        Vince Weaver <vincent.weaver@maine.edu>,
        LKML <linux-kernel@vger.kernel.org>,
        Alexander Shishkin <alexander.shishkin@linux.intel.com>,
        Ingo Molnar <mingo@kernel.org>, Kees Cook <keescook@chromium.org>
Subject: Re: [PATCH v2] scripts: add script for translating stack dump
 function offsets
Message-ID: <20160917184833.6qsvlzxfc2bziuyo@treble>
References: <alpine.DEB.2.20.1609142224480.12612@macbook-air>
 <CABPqkBQZTFuMKYX62PXjdHtZRKxKkj=emQA3SepAidLj6tAWVg@mail.gmail.com>
 <20160915072425.GN5008@twins.programming.kicks-ass.net>
 <20160915121014.ox5ytlplt7wz5cpk@treble>
 <20160916144807.6yrdznupo3bpe5b2@treble>
 <CA+55aFwa4so_H-yjgzV5gU1OyCapU7=-hY5LTcMFHfgqsPuXeQ@mail.gmail.com>
 <20160916191738.v3kq3c44zmdsvlgb@treble>
 <CA+55aFz_=-WQMZ3exuSEzNUzdB_ica8VZtCbf3wsj1XGFOTS+w@mail.gmail.com>
 <20160916212656.bnmxrl3cglsbjmpm@treble>
 <20160917081525.632afu7ddw3osgop@debian>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20160917081525.632afu7ddw3osgop@debian>
User-Agent: Mutt/1.6.0.1 (2016-04-01)
X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.29]); Sat, 17 Sep 2016 18:48:35 +0000 (UTC)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Sat, Sep 17, 2016 at 10:15:45AM +0200, Rabin Vincent wrote:
> On Fri, Sep 16, 2016 at 04:26:56PM -0500, Josh Poimboeuf wrote:
> > +	addr2line -ie $objfile $hexaddr
> 
> Could you pass in -f and -p too to addr2line?
> 
> Before:
> 
>  $ scripts/faddr2line ~/dev/kvm2/vmlinux free_reserved_area+0x90
>  /home/rabin/dev/linux/include/linux/compiler.h:222
>  /home/rabin/dev/linux/include/linux/page-flags.h:149
>  /home/rabin/dev/linux/include/linux/page-flags.h:154
>  /home/rabin/dev/linux/include/linux/page-flags.h:287
>  /home/rabin/dev/linux/include/linux/mm.h:1778
>  /home/rabin/dev/linux/include/linux/mm.h:1785
>  /home/rabin/dev/linux/mm/page_alloc.c:6599
> 
> After:
> 
>  $ scripts/faddr2line ~/dev/kvm2/vmlinux free_reserved_area+0x90
>  __read_once_size at /home/rabin/dev/linux/include/linux/compiler.h:222
>   (inlined by) PageTail at /home/rabin/dev/linux/include/linux/page-flags.h:149
>   (inlined by) PageCompound at /home/rabin/dev/linux/include/linux/page-flags.h:154
>   (inlined by) ClearPageReserved at /home/rabin/dev/linux/include/linux/page-flags.h:287
>   (inlined by) __free_reserved_page at /home/rabin/dev/linux/include/linux/mm.h:1778
>   (inlined by) free_reserved_page at /home/rabin/dev/linux/include/linux/mm.h:1785
>   (inlined by) free_reserved_area at /home/rabin/dev/linux/mm/page_alloc.c:6599

Yeah, I think that's much better.

-- 
Josh