From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S936181AbcIROwU (ORCPT ); Sun, 18 Sep 2016 10:52:20 -0400 Received: from mga02.intel.com ([134.134.136.20]:31834 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934363AbcIROwM (ORCPT ); Sun, 18 Sep 2016 10:52:12 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.30,357,1470726000"; d="scan'208";a="10969068" Date: Sun, 18 Sep 2016 07:52:11 -0700 From: Andi Kleen To: Jiri Olsa Cc: Andi Kleen , acme@kernel.org, jolsa@kernel.org, linux-kernel@vger.kernel.org, wangnan0@huawei.com, sukadev@linux.vnet.ibm.com Subject: Re: [PATCH] perf, tools: Handle events including .c and .o Message-ID: <20160918145211.GM3078@tassilo.jf.intel.com> References: <1474160566-8955-1-git-send-email-andi@firstfloor.org> <20160918090327.GA10394@krava> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160918090327.GA10394@krava> User-Agent: Mutt/1.6.1 (2016-04-27) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Sep 18, 2016 at 11:03:27AM +0200, Jiri Olsa wrote: > On Sat, Sep 17, 2016 at 06:02:46PM -0700, Andi Kleen wrote: > > From: Andi Kleen > > > > This is a generic bug fix, but it helps with Sukadev's JSON event tree > > where such events can happen. > > > > Any event inclduing a .c/.o/.bpf currently triggers BPF compilation or loading > > and then an error. This can happen for some Intel JSON events, which cannot > > be used. > > > > Fix the scanner to only match for .o or .c or .bpf at the end. > > This will prevent loading multiple BPF scripts separated with comma, > > but I assume this is acceptable. > > > > Cc: wangnan0@huawei.com > > Cc: sukadev@linux.vnet.ibm.com > > Signed-off-by: Andi Kleen > > --- > > tools/perf/util/parse-events.l | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/tools/perf/util/parse-events.l b/tools/perf/util/parse-events.l > > index 7a2519435da0..64ca26e4ed2d 100644 > > --- a/tools/perf/util/parse-events.l > > +++ b/tools/perf/util/parse-events.l > > @@ -162,8 +162,8 @@ modifier_bp [rwx]{1,3} > > } > > > > {event_pmu} | > > -{bpf_object} | > > -{bpf_source} | > > +({bpf_object}$) | > > +({bpf_source}$) | > > why are the () braces necessary? anyway: Flex complains otherwise, I think because it's used with OR (|) -Andi