From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753882AbcITB4l (ORCPT ); Mon, 19 Sep 2016 21:56:41 -0400 Received: from shards.monkeyblade.net ([184.105.139.130]:40728 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753831AbcITB4j (ORCPT ); Mon, 19 Sep 2016 21:56:39 -0400 Date: Mon, 19 Sep 2016 21:56:33 -0400 (EDT) Message-Id: <20160919.215633.1223352245725461474.davem@davemloft.net> To: baoyou.xie@linaro.org Cc: yisen.zhuang@huawei.com, salil.mehta@huawei.com, yankejian@huawei.com, huangdaode@hisilicon.com, lisheng011@huawei.com, fabf@skynet.be, xieqianqian@huawei.com, lipeng321@huawei.com, weiyongjun1@huawei.com, liguozhu@huawei.com, arnd@arndb.de, andrew@lunn.ch, chenny.xu@huawei.com, xypron.glpk@gmx.de, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, xie.baoyou@zte.com.cn Subject: Re: [PATCH] net: hns: mark symbols static where possible From: David Miller In-Reply-To: <1474189645-6165-1-git-send-email-baoyou.xie@linaro.org> References: <1474189645-6165-1-git-send-email-baoyou.xie@linaro.org> X-Mailer: Mew version 6.7 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Mon, 19 Sep 2016 18:56:39 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Baoyou Xie Date: Sun, 18 Sep 2016 17:07:25 +0800 > We get a few warnings when building kernel with W=1: > drivers/net/ethernet/hisilicon/hisi_femac.c:943:5: warning: no previous prototype for 'hisi_femac_drv_suspend' [-Wmissing-prototypes] > drivers/net/ethernet/hisilicon/hisi_femac.c:960:5: warning: no previous prototype for 'hisi_femac_drv_resume' [-Wmissing-prototypes] > drivers/net/ethernet/hisilicon/hns/hns_ae_adapt.c:76:21: warning: no previous prototype for 'hns_ae_get_handle' [-Wmissing-prototypes] > .... > > In fact, these functions are only used in the file in which they are > declared and don't need a declaration, but can be made static. > so this patch marks these functions with 'static'. > > Signed-off-by: Baoyou Xie Does not apply cleanly to net-next, please respin.