From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S938259AbcISIQ0 (ORCPT ); Mon, 19 Sep 2016 04:16:26 -0400 Received: from mail-sn1nam02on0062.outbound.protection.outlook.com ([104.47.36.62]:63232 "EHLO NAM02-SN1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S936533AbcISIQE (ORCPT ); Mon, 19 Sep 2016 04:16:04 -0400 X-Greylist: delayed 1046 seconds by postgrey-1.27 at vger.kernel.org; Mon, 19 Sep 2016 04:16:03 EDT Authentication-Results: spf=none (sender IP is 165.204.84.22) smtp.mailfrom=amd.com; linaro.org; dkim=none (message not signed) header.d=none;linaro.org; dmarc=permerror action=none header.from=amd.com; Date: Mon, 19 Sep 2016 15:43:46 +0800 From: Huang Rui To: Baoyou Xie , CC: , , , , , , , , , , , , , , , Subject: Re: [PATCH] drm/amd/powerplay/smumgr: mark symbols static where possible Message-ID: <20160919074345.GA4278@hr-amur2> References: <1474270119-8500-1-git-send-email-baoyou.xie@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <1474270119-8500-1-git-send-email-baoyou.xie@linaro.org> User-Agent: Mutt/1.5.21 (2010-09-15) X-EOPAttributedMessage: 0 X-MS-Office365-Filtering-HT: Tenant X-Forefront-Antispam-Report: CIP:165.204.84.22;IPV:CAL;CTRY:US;EFV:NLI;SFV:NSPM;SFS:(10009020)(6009001)(7916002)(2980300002)(428002)(24454002)(199003)(189002)(23726003)(305945005)(97756001)(106466001)(4001350100001)(15975445007)(47776003)(586003)(16796002)(356003)(92566002)(101416001)(46406003)(33716001)(33656002)(5660300001)(87936001)(105586002)(4326007)(11100500001)(54356999)(189998001)(77096005)(1076002)(626004)(83506001)(5001770100001)(9686002)(2950100001)(26826002)(76176999)(50466002)(2906002)(50986999)(19580395003)(8936002)(8676002)(86362001)(7846002)(246002)(18370500001)(107986001)(5001870100001);DIR:OUT;SFP:1101;SCL:1;SRVR:SN1PR12MB0574;H:SATLEXCHOV02.amd.com;FPR:;SPF:None;PTR:hybridsmtp02.amd.com,hybridsmtp.amd.com;A:1;MX:1;LANG:en; X-Microsoft-Exchange-Diagnostics: 1;DM3NAM03FT025;1:NSvjjKyg72YZ0k2BqEjVzsNANMjrSPzM9O0dsK6c2M8NfNqsZSdP8ORjWXEkJVr9PkLYK3X2POzcbz+ttriyKLrvBorqdvgZPO1ov4IQnlGE8uXnRWbRR+lTMM/vA2eFSs8KodcC0f+x+MolNUt42zstt6qEgGYAN3QG6OM2iN80SRsyQmkhb5cXbcauobGGE2xVfAjpd86Qw7FEPrhAZOGoU7r0JoFQu8az0t2yzCrWrn3uAunJdqCJtyIDcGmp2syojmitvJwN3XG1XIIm/Nm2jAy5LqlLaNUmAEcf/mHBcBzO85magdjxyLscPfUtChf/WihaG+KlnE1m1XqZwr+lpc3Jw/jxFubdb1XUg6gV/IUDbmgnBAhaY1Pj7Iwars5nmTB/ioRDq4FwQFHdcrgdnvMmNuV8plyFqxMaLgIiPstOMZWHfKoHY+HYjCeEGxtFF/f1zpAKE/srZj0dWA46rjyQgY0xXNoeabs3sCh0QqZy03NF0k379Tm9irAABWcx0M8cohMC3BC9SiDW8g== X-MS-Office365-Filtering-Correlation-Id: 63f29146-2f36-4cb9-2140-08d3e060915b X-Microsoft-Exchange-Diagnostics: 1;SN1PR12MB0574;2:JkRvYg+WIB8rEQRaL182HbCATag/MAjJ5ZGspfxUuqoe8UJjcB1jsChwooWeLXmJw/uS2sxGnl/sRedNqWD8EGizxBHXkhQBcJnDuyzjCVXvvQ2pXwiZ65EMOIbGZXodqSqc+FxLQXhX7z7pbEo/vnI1R23fsIv+7VDnWYxkLYh8u8z3fxUbv2QZK5QHLruV;3:qBVdC/UCyt+GYS6nyp2ZDMeYz9A2ro9LoVLAXx/rlvIBa6Z/yciuXeKHFX/d8kX0M49bOzLIY+ySs9XgXUmxbifxiNRB+PsbsRrF4lYdX9jPdOmmnSg4f9fiEB1eEsyH2G1Fad2snapFe7CATjDUyqcNnvnerXRCsSkdKd1hoOUClpt8Q4SiWzcwVmWwf2BeANkkaoZvQG6RIBF3yIJ9ejKqmaCxIQYwlllfM3Sz8bg= X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:SN1PR12MB0574; X-Microsoft-Exchange-Diagnostics: 1;SN1PR12MB0574;25:J5vrv+CPc2gQaUc6phugaNk/pQLJRwr6zkvhp/IvC9dwMMvEQQUxOwL9OGWeEYQ7L6vF2BMte9A7tZbSpBEm+tkVw9AaL6vv9hqLzq0XIW/Eua/4aE9+sJRLzMF3ektYuxzIDmnI96cFGVY61InQmPlvrtSVtkslkOF0RawF6Yi9maLJQDQlMZ/za29ppiys/lNM+UR96/u6fl9NQ3zc2gEV0eCQ5G8Riz/LYC/NZ2b0haHsgqzIx6VAQ3fnsKDt76/j7LbvTG8KrdWP9ymj096pV9wHzqhqQREb+gkhDLUBHtXhaCF/rD/Zpvjj53E3Pd3l2cbcNqEdUzZFz3TerqO164pbvfYuA15tGcjApSzuc79bIS3f1BoIWwQLFpif7o/yT/DrZdXC605SUnPIHjJFxWeL0ZiKegInEsan8LzC+8lsPNzQFqe6SKCcaPCSE3iWMIrGYF/gmUWfTzWlQqkpEwfzyzSvYZWTfkjR2lGrRQjnzIihG4ZtefVZGTXjZ+D+8P7P/ldbcbz+xMRGo4lwD+iMAfDQTmfxMiHdo/zw64GNf3ADw2OLymIrhluDWU8oyaWC4DK5aQ/rl0x9vqrBv5ojAVRqMhpURk6TaEEt5b8+AO62ysdI5Ki7X69FtGW/u1UaW0JjBwFsZrdeYuLmmHAjeNc6lo3psiGkDpMcQ333R4cmQtS81a1rkbNsZBV9TeRPDKVGB4CIGGWE8g94mAD5C/fOfg+qf6FpVLqUbboZpCP7EMN88qEuBIgoRXizPGMiPswB7Ll74IZbUMak+qbR9ynx38uNmQ9Wg5q8PIm4HXvwXxrk798e1UjJhptPcsLfmLImLHxqfEs7Mc64M7XBX3oZDwSeiC3Ec0Q= X-Microsoft-Exchange-Diagnostics: 1;SN1PR12MB0574;31:W5/+I3xR7wYXYxHQiE/bJVz6wing6qeJEIqbv18MJyd30CmVDkPQLVHWtJwGuVV47Kzob0qGLfFbPjzYh/aYwqT5MxA7Mt4pRFAw8c7n4Xq7AQEDkJY9jUyXUYCvP3bec02/WFRrvot1xCCDS9Ys5FgiJD5CptUKVuv4w5n5p1f/JSP45ZgoH7t9FAwGKP/F0c9A4ld1jpfRlqPU6YKtEkzS2Nmc6bg1NbBe9uQ3pyc=;20:giu4sIyYwRZauMGijM24qy7nea7HArRteBIZ+St8stuEDf1lxYqneONEY8lmRzrcgIBhtjC22GOYkOglRK8zy/yoYGr9Zq3KafMrj2HnqIb+Zjh1y49dqzjFGeqSsSL4eM+n7OR1FAEWn1IEMZIb6b2+oCmcMCGvcCNwALmvq0bjddudWsIKemToV4JwjpGaQR3Zxa++Yw5do/JcrmN/8am8sx4rVJUxSG9gGH0Ih1JtqysQBV1Cl1zwdJ1G5qm40mh8ORC3t1oN5JEdKcmLvll3DNeAJHZjccIUHV+YT0tKSwvzawjph+oEsOcR1KdhF06wbE6gkzEfKaZMkJDy5Rja8vEU368/WpchGcBSQU7lrU4XKjr+XRvFyHLz892/wTY8jGVlz01vUbqnDk+iShDWS48k38cTTqJUi3cTRj+o+OcwvOypOdnqGqmIUE/56IrvC0SQflET7Zjj+X4iIr+gAghijGQrsrAdhgPF/9TA7g5AbX/zTDqYQLcpMuC0 X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(217544274631240); X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040176)(601004)(2401047)(13023025)(13021025)(13013025)(8121501046)(5005006)(10201501046)(3002001)(6055026);SRVR:SN1PR12MB0574;BCL:0;PCL:0;RULEID:;SRVR:SN1PR12MB0574; X-Microsoft-Exchange-Diagnostics: 1;SN1PR12MB0574;4:hFPQ1RYyPoRHhwoEQCPCh89iNbAYLhq2IXYCroq0jAp+wPAmYEDLGcLYrtWScX7tU6kSFCjY9aKJKY7rwBgQIUoyQdYrj0QeCX9K6GbyLV6h4l0aNdRuqDd4cZI/TS8KrXhuLi3Vkd0fZe3gTJuPCh7UV0FfE6PC5xaWX2U49dTZtyspMIltihPFVBayFHJJc7OLQh7mqaFq4UJwgClzZH2mlUN9l3VhSdo1v55Hn0cIDzryfuLUzR6Xl2nBUeTAGen1uCTxyrrO5l5b2fRcIoal7njESQqx2ikHCCZ5SmFklEserPXSGVvM3FYLpwqpoKjQKoiCmW11gYYbWKJc+3Iyvh6W8BglYIVs412ITK6w8qVRodhwZIUlBqmDoVPOZz1eAo5Tle366SychTLaR/CIE4V5IiTkg0OpKB0oIJftHtN7Ue7f3GujYmLzlBMEJCFi0g6MdCrzfEhXzeV8a499cvpsR8AbFOVquf2p5xJwhVISFAXWJLaKVIjjaMRy X-Forefront-PRVS: 0070A8666B X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1;SN1PR12MB0574;23:hcMBU1TRvx8a1xmuzmtFP+o0ccYdubGnFhFaZYERF?= =?us-ascii?Q?+UqU4ETGhE34IfVC2+VGvy3PyCwFwOY7FMclaReE+3go4M0XJ7F1hYX8iyEY?= =?us-ascii?Q?GN+IBVx6rkGKsypyldAlcaM2UNK/3i2l6kIMV1NZOj4hws4RcS6IVEFkGk7b?= =?us-ascii?Q?qNn/9kkWWDW484R5sXOF7O7IfVkOvftwzk+sRObh4U7pXRS+LQVofqGSHKtI?= =?us-ascii?Q?en2tTeOSGK6U4HPfu1UKrB20fMuGkW/+MGLKf5/1syCpV9wxY0cv9TQQmqDI?= =?us-ascii?Q?SnSUhp6z/aD6g9nfwsxOEHWdMdQPNWsibtNi13LSW5J8wu0ZE8cCv6NmkisA?= =?us-ascii?Q?8vUdm2X32k+BtKLgFbyOtUocASAke+jaRucpMGdEn6+CTgU2DqD8dh8uX0Mz?= =?us-ascii?Q?tUgQbI5xnqCil3foVnmPpN8R6Y9/IJheppmmMxMmm4nJJBaEJMGkVLGCSF5w?= =?us-ascii?Q?UnjGzNbgi4c0l4D5nAaPZ3OZSX/+V/Vylbk6Qm7+1gyLyRsqYfNvJbYowK5f?= =?us-ascii?Q?svqGjKNBRtyMZkd6wtccTjvj3Ajad1kbaZkz/HvQEYYGAL7DNctYIMZlod19?= =?us-ascii?Q?sY+pchTlTFiF/Th/1gWtT3x6BpTdf1XEs4BbJ1n3CyPJvDCPOU+dZM5vqbwG?= =?us-ascii?Q?EXV2EMLPWsvqehn/+XJxIQoCUsVGh7tr2HcOzKIaTHFQAO7GI3BFIiu1/vh3?= =?us-ascii?Q?P9feJ0SiRcGQrfp3MkMOe5/53tgDqnhiavhPFzPFCV2Mf665Av85aPiCS5Pb?= =?us-ascii?Q?iWm3CUO3wPqF5yqPcAnb0sA1/LwBMsxKGtrK1zFYwtqnZZm8/rhh8Pel7nzt?= =?us-ascii?Q?xxsfX7vKYv5TGznUIqmq8evtPk0nRgM8QnOqrb7kqzVmpzSoFoZoZmFZ6NLh?= =?us-ascii?Q?Y7ft9R84tIZeHaSANab9N1OnQeq/2JCAG7/XLBE1iBbAkh47pcFQHa9RUn84?= =?us-ascii?Q?a1DdRAsrwyIMLlFLVmbsRgMZQph44CJDnINrGORBUr9uKVtS9qDhpQftAtuK?= =?us-ascii?Q?MuVf0HWqD/iSejKWieTm9nkQB4B2xPwUYrEsZhEt7FMrm6q8uvCkB/P0pCj3?= =?us-ascii?Q?QJLbtitORP0iRGssCraqkqqzcvhQF6E6LhxCBlwYXcccUA1KakJW23hI4o+q?= =?us-ascii?Q?wnFJC2Umho93j8nq49CM+w3QEbAXKOlWwFFP5fi/zEVZs9RkXZR+csJZHnss?= =?us-ascii?Q?jl3XD/1wejZlh1q3emLuVFjEFWlssBnYBssg9UIz5yYiauyoNfZDjkqyy35f?= =?us-ascii?Q?49zY2NhhUebAYYVKx8=3D?= X-Microsoft-Exchange-Diagnostics: 1;SN1PR12MB0574;6:0QQxO1BnY6fTmGFyerdyvDuyxTanwlYOlIllBxjDR1BUrLqsMbOBFhxwrM1SrJXb/DrQHvF9zwpf2nTK7ATeOpV8MDLRqySIoMxNiMPVTdL0aOOYRocTaqNFTc1xq3mlfuiNLvQUwHScjwkMj6n8jzyK47i/cbZqBpjgqy00bc7w7uofiSPL1BcgKhF0X/ivLNxZ20yiX2yczzaqRDx4JC5bHvPxjdBYRNtSHCOd7DR/JqVM5fi6xmoH/74If3TmNIawdO4IYQQEbwkwX1oVekldks9LxpVGmMRnQkt4+eJ8gqaC/tjt1/tGD0kV3j1uZTaDkSMMMNTc8Jl2iIz1iQ==;5:0Jtd4ebzLz7Hqtot7krhGZfbCzvrFKOZzdYaStXenQLzB5QzNTBvAHXdrdzRIk4OrNprp8YDHJIcshnU4SXhCAu276qmZBUg5cd9eWYptCWjeDRqRn3Zcnn5zwZ4J3KwGUoHQ+qTigNFZxBZYj1E4g==;24:KRV7qdMwispnDcP9LOYzKrhHK6dy325eJUMrbMsIj4In8Zlb4ObOul1SxoM/xSGyUMmcWwUHQnYTKOOE282tCGvGDDMQGnjU09CIzeZOkAk=;7:djzWTXhZwREnCEUVMOhnaq08fdwi39zrBvOq9ROcbIHdJzqzBQH2S0/Rhk8BfLnFgWuQCNH/SDeaXlcIxwuiOcQeEVkfkQ3i078IaeAIReRENO/6tGdKZzgn88yo7csD4Khzj9wR3K4fB17He/CnIuLWsUAoeL2oUYsj7yYVSwMiVCldHbQN0mIGW6/KV6Hi8MTatfN4oIilCBzPY7aP2qMsL3IdNngOhKS/BrbxeJHB3vlQAWilxvep0hSqfTCFZN0JgCd7m/BvY1nAadMNysia8KAIMJhK/TZ8MiVRUroBitHpqNfuVZuuo/2QZlgj SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;SN1PR12MB0574;20:2H8yA2UihKYlZkSPCL22PwDh72ytkTKF3HP7GQhSYtgaQSlvSbWkrP47ycFrKnR+DsIei4s5ndMtK+wdpAKw3WZbWgR9sg0XBY0CcNITUvpSgWILKDGBz3eqvj4jblduRwhxpoGleVvycMoGvJh/9zjNTimMCSZRwWQPSz8DlAjXcqUJh+njhXwnDSSqnvnUkSJso623fDHsPKmIVjFJsIwD8+sohRHXUKot9jJXSCOWXXHLJiKxtCOU128Revyi X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Sep 2016 07:42:54.5148 (UTC) X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.22];Helo=[SATLEXCHOV02.amd.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN1PR12MB0574 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Baoyou, On Mon, Sep 19, 2016 at 03:28:39PM +0800, Baoyou Xie wrote: > We get a few warnings when building kernel with W=1: > drivers/gpu/drm/amd/amdgpu/../powerplay/smumgr/tonga_smumgr.c:146:5: warning: no previous prototype for 'tonga_program_jump_on_start' [-Wmissing-prototypes] > drivers/gpu/drm/amd/amdgpu/../powerplay/smumgr/fiji_smumgr.c:816:5: warning: no previous prototype for 'fiji_save_vft_table' [-Wmissing-prototypes] > drivers/gpu/drm/amd/amdgpu/../powerplay/smumgr/polaris10_smumgr.c:743:5: warning: no previous prototype for 'polaris10_avfs_event_mgr' [-Wmissing-prototypes] > drivers/gpu/drm/amd/amdgpu/../powerplay/smumgr/iceland_smumgr.c:167:5: warning: no previous prototype for 'iceland_program_jump_on_start' [-Wmissing-prototypes] > .... > > In fact, these functions are only used in the file in which they are > declared and don't need a declaration, but can be made static. > So this patch marks these functions with 'static'. > + amd-gfx mail list. Thanks to your patch. But powerplay part is refactored recently below, some functions are already updated. So you might need rebase them. :-) https://lists.freedesktop.org/archives/amd-gfx/2016-September/002118.html Thanks, Rui