From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S932389AbcISILD (ORCPT <rfc822;w@1wt.eu>);
        Mon, 19 Sep 2016 04:11:03 -0400
Received: from bombadil.infradead.org ([198.137.202.9]:53620 "EHLO
        bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1752725AbcISIKs (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 19 Sep 2016 04:10:48 -0400
Date: Mon, 19 Sep 2016 10:10:43 +0200
From: Peter Zijlstra <peterz@infradead.org>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: Wanpeng Li <kernellwp@gmail.com>, linux-kernel@vger.kernel.org,
        Wanpeng Li <wanpeng.li@hotmail.com>
Subject: Re: [PATCH] x86/apic: Fix suspicious RCU usage in
 smp_trace_call_function_interrupt
Message-ID: <20160919081043.GQ5016@twins.programming.kicks-ass.net>
References: <1473920520-12220-1-git-send-email-wanpeng.li@hotmail.com>
 <alpine.DEB.2.20.1609151055190.5412@nanos>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <alpine.DEB.2.20.1609151055190.5412@nanos>
User-Agent: Mutt/1.5.23.1 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, Sep 15, 2016 at 10:58:04AM +0200, Thomas Gleixner wrote:
> On Thu, 15 Sep 2016, Wanpeng Li wrote:
> > ---
> >  arch/x86/include/asm/apic.h | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/arch/x86/include/asm/apic.h b/arch/x86/include/asm/apic.h
> > index 1243577..71c1fe2 100644
> > --- a/arch/x86/include/asm/apic.h
> > +++ b/arch/x86/include/asm/apic.h
> > @@ -650,8 +650,8 @@ static inline void entering_ack_irq(void)
> >  
> >  static inline void ipi_entering_ack_irq(void)
> >  {
> > -	ack_APIC_irq();
> >  	irq_enter();
> > +	ack_APIC_irq();
> >  }
> 
> which makes ipi_entering_ack_irq() the same as entering_ack_irq() and
> therefor pointless.

entering_ack_irq() seems to use entering_irq() instead of irq_enter().
Which is close but not the same. This thing seems to also do
exit_idle().

Now, there's only a handfull of ipi_entering_ack_irq() users, and it
doesn't seem to make sense to me to only call exit_idle() on IPIs, why
don't we need to call exit_idle() on regular IRQs ?!

All in all, that stuff is crufty and needs a cleanup I'd say.