From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S938930AbcISNQP (ORCPT ); Mon, 19 Sep 2016 09:16:15 -0400 Received: from mx2.suse.de ([195.135.220.15]:45765 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965354AbcISNPl (ORCPT ); Mon, 19 Sep 2016 09:15:41 -0400 Date: Mon, 19 Sep 2016 15:16:19 +0200 From: Joerg Roedel To: Paolo Bonzini Cc: linux-kernel@vger.kernel.org, kvm@vger.kernel.org, David Gilbert , Radim =?utf-8?B?S3LEjW3DocWZ?= Subject: Re: [PATCH] kvm: x86: correctly reset dest_map->vector when restoring LAPIC state Message-ID: <20160919131619.GE3138@suse.de> References: <1473889712-13785-1-git-send-email-pbonzini@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1473889712-13785-1-git-send-email-pbonzini@redhat.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Sep 14, 2016 at 11:48:32PM +0200, Paolo Bonzini wrote: > When userspace sends KVM_SET_LAPIC, KVM schedules a check between > the vCPU's IRR and ISR and the IOAPIC redirection table, in order > to re-establish the IOAPIC's dest_map (the list of CPUs servicing > the real-time clock interrupt with the corresponding vectors). > > However, __rtc_irq_eoi_tracking_restore_one was forgetting to > set dest_map->vectors. Because of this, the IOAPIC did not process > the real-time clock interrupt EOI, ioapic->rtc_status.pending_eoi > got stuck at a non-zero value, and further RTC interrupts were > reported to userspace as coalesced. > > Fixes: 9e4aabe2bb3454c83dac8139cf9974503ee044db > Fixes: 4d99ba898dd0c521ca6cdfdde55c9b58aea3cb3d > Cc: Joerg Roedel > Cc: David Gilbert > Cc: Radim Krčmář > Signed-off-by: Paolo Bonzini Good catch, thanks for fixing this.