From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932197AbcISTFE (ORCPT ); Mon, 19 Sep 2016 15:05:04 -0400 Received: from mail-db5eur03hn0233.outbound.protection.outlook.com ([104.47.10.233]:24541 "EHLO EUR03-DB5-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751888AbcISTFB (ORCPT ); Mon, 19 Sep 2016 15:05:01 -0400 X-Greylist: delayed 8162 seconds by postgrey-1.27 at vger.kernel.org; Mon, 19 Sep 2016 15:05:01 EDT Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=rkagan@virtuozzo.com; Date: Mon, 19 Sep 2016 19:33:45 +0300 From: Roman Kagan To: Paolo Bonzini CC: , , , , Subject: Re: [PATCH 3/4] KVM: x86: introduce get_kvmclock_ns Message-ID: <20160919163344.GB11067@rkaganb.sw.ru> Mail-Followup-To: Roman Kagan , Paolo Bonzini , linux-kernel@vger.kernel.org, kvm@vger.kernel.org, rkrcmar@redhat.com, den@openvz.org, peterhornyack@google.com References: <1474285153-4216-1-git-send-email-pbonzini@redhat.com> <1474285153-4216-4-git-send-email-pbonzini@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <1474285153-4216-4-git-send-email-pbonzini@redhat.com> User-Agent: Mutt/1.7.0 (2016-08-17) X-Originating-IP: [195.214.232.10] X-ClientProxiedBy: AM4PR0501CA0011.eurprd05.prod.outlook.com (10.167.83.149) To VI1PR0802MB2480.eurprd08.prod.outlook.com (10.175.26.23) X-MS-Office365-Filtering-Correlation-Id: 563e4da2-7eca-4f95-c3fb-08d3e0aabcf1 X-Microsoft-Exchange-Diagnostics: 1;VI1PR0802MB2480;2:SWFxxKY9q/Y/mpMXjLSrlBMON8Brt7X6qX3yZOyY9zOLtleroIIuDCPjXJIqnW11QDtuRXx+i0/wgJDixaZtD6xaDEVRFXHeITN8EWBiuYS9Vc1V+ZBWVroxQVr0O4fgt28zpLjqAqPDWt6ZkDuGaQYGWdK9dDI/vbUioOYPUUwC62gMhMkILBBoVVvFr686;3:lnC4cJef0s46lxINF0Q7b925jsoJ7Z34Vcu2IwMKAXtbn0nWIqMSWTfQ+cGF/PAKRveMQ0MK4ZkLnICnprCHrhLNmvxZfEjWv9DjPYBGfF6lYjFMBM3/nNO9C0F3R91m X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:VI1PR0802MB2480; X-Microsoft-Exchange-Diagnostics: 1;VI1PR0802MB2480;25:jbs7lh2OCbf9UVU1yB3hXGLb+sDp63Effkor4gC7NPtg6aUBMmRk4a3GGn6Kj0pAxFm7AowKG3VBxPHZHeQcogmXZxE94owj5cHnLj7TGaXd9yPt/SmQqyoF5qx4sBYNw9Nyk4V3QrQsP0kSZJXbihzc9kHe4H6kob57nzQ1yJhNct8rqd/azmB1/ySv0+Quk4kjEPRijlY6DSsecyw0v6pbNw+JS+8g2p0wBa6Hcebw0z7jDJHifRx/R32tVch1G0ZJlqp7d5U4Nw2qRlaVzAk/Bzv0JTQtIJl+aM4qr7gJIC8LuzcwwpFLHNjQfqEAN9fi++4vGB04+Gxv0+UktSvkBreSov4+7bO20toXyYMB9SG21A/4ZmPvOzQav0gbUGVW4Gt5cEHh3u6JnNB1gL6XNkf1M9Ol9HqIAgPfSdWhJ64UD4Y2A/1kX1THM+lrf/vCjZFii6Y31PVLcXI8/i/kwWjhG/r6zLB65+REKYDKwFpRuYkhf5Ga/QZswR8NNGBFAGgliQlu2lFo9iYNAR2azVKr3l8+Deox2fhlDnz6MnKHCOsUib6iA/87sI/0jWyMl4rBYO1QM7K5D4jeKRcYIsTSLz8ion7x8IU6Nxjii5pOEANdhU7tabflfY1r1D/0kFP/HRbc13YfC2garTOp6RZ4YUVsuaCwcl6HomLrGAkOujafwH1Voi8IoehZAYilgi3iJUrFZIU/yOmROQ==;31:/4qqrmYi/j9Jh3HK8xX8im108WifUlMOY6IUbVSM4TLx1VFu5F1nDbj8JAbdpHDpc+ug1x9AsZNdnzky9JY3uJL09G86PG54N5YCxuQmVrPvMp/JjyWIWTrwOzSiUy9zRwVojK44645AUikhJWYuJtPcAiyfU2nnLU744CW1yaPmFTNZCM2tz8vKrCkZcyaVlWPWwOa1t7KGKXMVIaBINzGNGUE/YhoAVk07Gi7YbOU= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040176)(601004)(2401047)(8121501046)(5005006)(10201501046)(3002001)(6043046)(6042046);SRVR:VI1PR0802MB2480;BCL:0;PCL:0;RULEID:;SRVR:VI1PR0802MB2480; X-Microsoft-Exchange-Diagnostics: 1;VI1PR0802MB2480;4:b4eJ9HDu13GIPl6BJ+EgsXbn5CzKzq6bPinrbh/nUYR41JPt1ISS9rJeVG6tDYw8wX/2S4TlaiHoi0ExsDd3f1kWFGgdO8KlfV4krFONSXcCbTwCb6qh6eDdIJxs+1lNzF28o5mtxzAUyqREx2OylEUx8qQwIwkG9wsGcrNZvq+7nTkdteKkeqqeHYP7d42oP/De9kVRFH7VFo0GbLRXoY8T1cNgIklp++0PLLF3VmAgzbmjMy9B3CZmdQ1vH9FTUTK62r9mx4FlzSXJyv03NupPar1p9wxz2caBnPStd+Af2z935KIT+a/Pzrx/7Wotsli7fHV3T9dh4wra4jOS1PB1aJ6vYDDZ+BwGYemNcQPspQak7phN9aKccqoRGBx2NtlfvFEaMKOObylRftbuCWbsVB/1GKfp9iKJbPlrsJo= X-Forefront-PRVS: 0070A8666B X-Forefront-Antispam-Report: SFV:SPM;SFS:(10019020)(4630300001)(6009001)(7916002)(199003)(24454002)(189002)(97756001)(101416001)(110136003)(92566002)(2950100001)(189998001)(5660300001)(106356001)(54356999)(33656002)(36756003)(46406003)(77096005)(42186005)(68736007)(50986999)(4001350100001)(97736004)(53416004)(105586002)(76176999)(47776003)(69596002)(81166006)(81156014)(9686002)(23726003)(6116002)(66066001)(3846002)(2906002)(1076002)(19580405001)(586003)(7736002)(7846002)(50466002)(83506001)(8676002)(4326007)(86362001)(305945005)(19580395003)(30126002);DIR:OUT;SFP:1501;SCL:5;SRVR:VI1PR0802MB2480;H:rkaganb.sw.ru;FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1;VI1PR0802MB2480;23:mHp3r91ecC1S7GX75jOeJrXUFZoZ/b8xETC9Er0?= =?us-ascii?Q?9quRohjNU7Tds6V50rUwwEby7EGeIIF28L8cQuXtmr1z4hUSb/c3VUtKKzhP?= =?us-ascii?Q?flNfwDSKBDcEmTvg5GfsCwlrVeQhN4uCdkDMJHFaQKapk2DaARHdrlT/C5bs?= =?us-ascii?Q?I7/o8hCX4pFia/pi+AvNzEA/xhy849rMswM/bczF4/38PGcNBbpbZCSGvaoY?= =?us-ascii?Q?dwK3J34irRIKuaJslRIXCaK+jbkMKHibPeRrusIbmc87oq4znAJYBaCwSnei?= =?us-ascii?Q?NC+QPAO2gO2R+6aZQNyUh3OpmgHQjqHyvImFhWhVQFUK38DnjMg6uxYxHnMY?= =?us-ascii?Q?TelYyJ/z8+padnDHApx5nHwC9hiqfIvhUOMAgF96+3A5uqAyufbrkJkxfItI?= =?us-ascii?Q?+WoQfME3m1LJw3ubOnFtHJRmJ6eyAha8e0fVL/eIy3cLqk1zGcmh7RCr4TOH?= =?us-ascii?Q?NEib/Sw4wurvi1Rv/4sgRazLRH8Zhg/GzNIetffer7BI4wTT6yr5IBZ8YaeS?= =?us-ascii?Q?jOpvU5lBdCExj7C2NQuEqQcUQJu3C03Goe9YZanTGBIBzL1uSkoXI6o1mHtk?= =?us-ascii?Q?jMXMjo5RPGO9RMrjPENi6PeJLMYO1w/uog3537jvqEau2bkmuaTuUoqawh4O?= =?us-ascii?Q?UvwBwiHZkFfA+oOiJwmDGeW5VNG2wsbZ36H5uFRJbAMSDIqEx5hcNJDDDJN2?= =?us-ascii?Q?IsYeJmpyXhKTVkcLzEdH3IDOGJHZpVJW0wFE1OAZ+Ft/aU+gZ+UsQHbi9Wec?= =?us-ascii?Q?gDbKaHybVHVxEfS2IUz+KBopnsffc9NMwkax4GoGRElEfrgCkjYAQsvz7aQC?= =?us-ascii?Q?ojV8I1FNJvEtaBKOM7Y32CMr+IUQMhNXfd9QD8cRIcmbt3WGfn5oJyBm8Qqz?= =?us-ascii?Q?SXr6J9Aqx+P+y0EsmELKCRaHnmKMywBlqawtWy8rkN+43+9GPhWQpSDM4O8t?= =?us-ascii?Q?Futxu1sMnbUJj+RcbgMA9FCykknVW0npiXSs/CgBvEEgGmfCWX2nNUh16JgT?= =?us-ascii?Q?dbdASgC/7UETO9PhmXnEsVv4AKV4QcPLI18Ns/908r9HA6rjtzkwstuZTgwh?= =?us-ascii?Q?rI3zXC5KcXbkeLrlMMLAggV5TQJONyZkRvLrkWgrEiEU552LaDCCJ31upvQd?= =?us-ascii?Q?qVPV2xz/+tsb+Q6j2l1wICO8VdP8s0RgnhjWHNajmR0v7vFa81SSKhtfXjo+?= =?us-ascii?Q?PKxoVkCgCxgCoS0GQuSq64a7my7GzbPuCtTa7pGlL43UbdW7gS8B/icnN7nc?= =?us-ascii?Q?h5WnNktF8splqTRnpWf89YfsZQKazlUwF9vd+14r2?= X-Microsoft-Exchange-Diagnostics: 1;VI1PR0802MB2480;6:syxeBblBc/eCX0/5GyIRcQSBy/Dvs1htX49uuzunaqf6EuLLSnuRuL/a9wBE8RhnCuRBIxmOGkhBcnlFF0/UQuuNfjnUUStIvmeRxw94bznV+s3GrprnDRnhUCpnqJckeJtOSF7iUGcMBx3H39847Lh/M1Fgi36G+BmDH+mcR60bK42kaP7tgnL0O/wZq7RZOF+SWxAaUX0F/3ggjXUkWe7+igE8hcOQd+FRLxZjwIenzAipxDuakzFZQYlKYWEi873loLyuh5vIIMC4GXumSHJZEByC48mhvo5nfO+PQI4Lic7lUgowSXzx7FT5qh6s;5:B4gkYnXMIXEgKa3TpH6PrfWfu89D4sttB1Ju/+9XeOPa3qwCiy5MWxekJXt4jefL1JayRejUTJWLgtF7KheTLghdg/VC8K6EsMqfgeb2X7RLbuApMpvLDuKh3H/BaUVKtYZYryDxWImEfKG5Xc1MlQ==;24:yJnmsfRmCJ9b8xNymcdbJbgzBW1cKsjKgscSY85QNolQ/7wlm2CXDqq6Xdznpjt9yp2NDjkpNqAE1QmYWMr2vg==;7:m+I8u8irgnbC19KXqkvww+fy5dHz6TaKAjEffxnK4r6uJE2OJE2lgk2MV7/4YMNJI6uSMmjTFz8SQpnh4kfBzJ0wIae8Fzfj09MO6q3xm/WC+aqKQaAOdANKtJ/ALJkRoezNvQ2064IWkBabuzS23DgaZZ/BzXqba/KM0MXnGRI37gx3k10ycIa7K/AS6SGUG2PPOkJLcliQpCCGsNQCVFsPL6Bh4B/EKflqJPfxv9tDcwr1OFihjSC5HdLr81I5vc/jLUPMdzkwTvHhlU5bozpj+E/rH73yvfD3BubETbFGVdwt5BGEMcx/UsMI8K2B SpamDiagnosticOutput: 1:22 X-Microsoft-Exchange-Diagnostics: 1;VI1PR0802MB2480;20:lF23J/Q7jDPseqSxqM22tFlErGYY54bbNi2q8Vu3zUTtBBHE+PJ77mOff0Akxm101zTc82qCiK6rX2tzLcQPxQ6buSogmFkLgibOLrnkpQnsLg1/0Oik6ktGY+twOBtaZeMzT51QmF+QtirA5aBU+QZvDb35uTvRLnUf5wNwT4Y= X-OriginatorOrg: virtuozzo.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Sep 2016 16:33:50.2219 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0802MB2480 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Sep 19, 2016 at 01:39:12PM +0200, Paolo Bonzini wrote: > Introduce a function that reads the exact nanoseconds value that is > provided to the guest in kvmclock. This crystallizes the notion of > kvmclock as a thin veneer over a stable TSC, that the guest will > (hopefully) convert with NTP. In other words, kvmclock is *not* a > paravirtualized host-to-guest NTP. > > Drop the get_kernel_ns() function, that was used both to get the base > value of the master clock and to get the current value of kvmclock. > The former use is replaced by ktime_get_boot_ns(), the latter is > the purpose of get_kernel_ns(). > > This also allows KVM to provide a Hyper-V time reference counter that > is synchronized with the time that is computed from the TSC page. > > Signed-off-by: Paolo Bonzini > --- > arch/x86/entry/vdso/vclock_gettime.c | 2 +- > arch/x86/include/asm/pvclock.h | 5 ++-- > arch/x86/kernel/pvclock.c | 2 +- > arch/x86/kvm/hyperv.c | 2 +- > arch/x86/kvm/x86.c | 48 +++++++++++++++++++++++++++--------- > arch/x86/kvm/x86.h | 6 +---- > 6 files changed, 43 insertions(+), 22 deletions(-) Reviewed-by: Roman Kagan