From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753536AbcISWXc (ORCPT ); Mon, 19 Sep 2016 18:23:32 -0400 Received: from down.free-electrons.com ([37.187.137.238]:46157 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751888AbcISWXb (ORCPT ); Mon, 19 Sep 2016 18:23:31 -0400 Date: Tue, 20 Sep 2016 00:23:19 +0200 From: Alexandre Belloni To: Pratyush Anand Cc: mingo@kernel.org, tglx@linutronix.de, hpa@zytor.com, x86@kernel.org, rtc-linux@googlegroups.com, linux-kernel@vger.kernel.org, prarit@redhat.com, dzickus@redhat.com, dyoung@redhat.com, a.zummo@towertech.it Subject: Re: [PATCH] rtc/rtc-cmos: Initialize hpet timer before irq is registered Message-ID: <20160919222319.qvakrltsv52gu2hc@piout.net> References: <19b150a2f1087b80757d62770d99833781e57b31.1473862685.git.panand@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <19b150a2f1087b80757d62770d99833781e57b31.1473862685.git.panand@redhat.com> User-Agent: NeoMutt/20160910 (1.7.0) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 15/09/2016 at 09:38:16 +0530, Pratyush Anand wrote : > We have observed on few x86 machines with rtc-cmos device that > hpet_rtc_interrupt() is called just after irq registration and before > cmos_do_probe() could call hpet_rtc_timer_init(). > > So, neither hpet_default_delta nor hpet_t1_cmp is initialized by the time > interrupt is raised in the given situation, and this results in NMI > watchdog LOCKUP. > > It has only been observed sporadically on kdump secondary kernels. > [...] > > Suggested-by: Thomas Gleixner > Signed-off-by: Pratyush Anand > --- > drivers/rtc/rtc-cmos.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > Applied, thanks. -- Alexandre Belloni, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com