From: Russell King - ARM Linux <linux@armlinux.org.uk>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: lee.jones@linaro.org, linux-kernel@vger.kernel.org, arm@kernel.org
Subject: Re: [PATCH] mfd/gpio: move HTC GPIO driver to GPIO subsystem
Date: Mon, 19 Sep 2016 23:33:07 +0100 [thread overview]
Message-ID: <20160919223306.GM1041@n2100.armlinux.org.uk> (raw)
In-Reply-To: <1474026770-22595-1-git-send-email-linus.walleij@linaro.org>
On Fri, Sep 16, 2016 at 01:52:50PM +0200, Linus Walleij wrote:
> Russell/ARM SoC: heads-up and ACK request.
Fine with one exception:
> diff --git a/arch/arm/mach-sa1100/h3xxx.c b/arch/arm/mach-sa1100/h3xxx.c
> index b1d4faa12f9a..75ab3b086e6f 100644
> --- a/arch/arm/mach-sa1100/h3xxx.c
> +++ b/arch/arm/mach-sa1100/h3xxx.c
> @@ -14,7 +14,7 @@
> #include <linux/gpio.h>
> #include <linux/gpio_keys.h>
> #include <linux/input.h>
> -#include <linux/mfd/htc-egpio.h>
> +#include <linux/platform_data/gpio-htc-egpio.h>
> #include <linux/mtd/mtd.h>
> #include <linux/mtd/partitions.h>
> #include <linux/platform_data/sa11x0-serial.h>
The includes here are arranged alphabetically with the exception of
linux/kernel.h, as per commit 4aa975558065 ("ARM: 5822/1: SA1100:
h3100/h3600: clean up #includes") - please keep them alphabetical.
Thanks.
--
RMK's Patch system: http://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up
according to speedtest.net.
next prev parent reply other threads:[~2016-09-19 22:33 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-16 11:52 Linus Walleij
2016-09-19 22:19 ` Arnd Bergmann
2016-09-19 22:33 ` Russell King - ARM Linux [this message]
2016-09-23 9:43 ` Linus Walleij
2016-09-27 19:47 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160919223306.GM1041@n2100.armlinux.org.uk \
--to=linux@armlinux.org.uk \
--cc=arm@kernel.org \
--cc=lee.jones@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®