From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752854AbcITAKs (ORCPT ); Mon, 19 Sep 2016 20:10:48 -0400 Received: from mga11.intel.com ([192.55.52.93]:31693 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751579AbcITAKr (ORCPT ); Mon, 19 Sep 2016 20:10:47 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.30,364,1470726000"; d="scan'208";a="1059223625" Date: Tue, 20 Sep 2016 08:10:13 +0800 From: kbuild test robot To: Andrej Krutak Cc: kbuild-all@01.org, alsa-devel@alsa-project.org, Takashi Iwai , Jaroslav Kysela , linux-kernel@vger.kernel.org Subject: [PATCH] ALSA: line6: fix ifnullfree.cocci warnings Message-ID: <20160920001013.GA15786@lkp-hsx03.lkp.intel.com> References: <201609200807.amTCnbAm%fengguang.wu@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <201609200807.amTCnbAm%fengguang.wu@intel.com> User-Agent: Mutt/1.5.23 (2014-03-12) X-SA-Exim-Connect-IP: X-SA-Exim-Mail-From: fengguang.wu@intel.com X-SA-Exim-Scanned: No (on bee); SAEximRunCond expanded to false Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org sound/usb/line6/driver.c:484:2-7: WARNING: NULL check before freeing functions like kfree, debugfs_remove, debugfs_remove_recursive or usb_free_urb is not needed. Maybe consider reorganizing relevant code to avoid passing NULL values. NULL check before some freeing functions is not needed. Based on checkpatch warning "kfree(NULL) is safe this check is probably not required" and kfreeaddr.cocci by Julia Lawall. Generated by: scripts/coccinelle/free/ifnullfree.cocci CC: Andrej Krutak Signed-off-by: Fengguang Wu --- driver.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) --- a/sound/usb/line6/driver.c +++ b/sound/usb/line6/driver.c @@ -480,8 +480,7 @@ static void line6_destruct(struct snd_ca /* Free buffer memory first. We cannot depend on the existence of private * data from the (podhd) module, it may be gone already during this call */ - if (line6->buffer_message) - kfree(line6->buffer_message); + kfree(line6->buffer_message); kfree(line6->buffer_listen);