From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933138AbcITPxq (ORCPT ); Tue, 20 Sep 2016 11:53:46 -0400 Received: from mx1.redhat.com ([209.132.183.28]:52668 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755070AbcITPxo (ORCPT ); Tue, 20 Sep 2016 11:53:44 -0400 Date: Tue, 20 Sep 2016 10:53:40 -0500 From: Josh Poimboeuf To: tip-bot for Josh Poimboeuf Cc: linux-tip-commits@vger.kernel.org, brgerst@gmail.com, tglx@linutronix.de, keescook@chromium.org, dvlasenk@redhat.com, byungchul.park@lge.com, fweisbec@gmail.com, luto@amacapital.net, mingo@kernel.org, hpa@zytor.com, torvalds@linux-foundation.org, luto@kernel.org, peterz@infradead.org, linux-kernel@vger.kernel.org, nilayvaish@gmail.com, rostedt@goodmis.org, bp@alien8.de Subject: [PATCH] x86/dumpstack: fix show_stack() task pointer regression Message-ID: <20160920155340.yhewlx7vmgmov5fb@treble> References: <703b5998604c712a1f801874b43f35d6dac52ede.1474045023.git.jpoimboe@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.6.0.1 (2016-04-01) X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.29]); Tue, 20 Sep 2016 15:53:44 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Sep 20, 2016 at 08:01:02AM -0700, tip-bot for Josh Poimboeuf wrote: > Commit-ID: e18bcccd1a4ecb41e99678e002ef833586185bf1 > Gitweb: http://git.kernel.org/tip/e18bcccd1a4ecb41e99678e002ef833586185bf1 > Author: Josh Poimboeuf > AuthorDate: Fri, 16 Sep 2016 14:18:16 -0500 > Committer: Ingo Molnar > CommitDate: Tue, 20 Sep 2016 08:29:34 +0200 > > x86/dumpstack: Convert show_trace_log_lvl() to use the new unwinder Ingo, My apologies, I introduced a small regression with this patch -- another rebase gone bad. Here's the fix: --- From: Josh Poimboeuf Subject: [PATCH] x86/dumpstack: fix show_stack() task pointer regression With the following commit: e18bcccd1a4e ("x86/dumpstack: Convert show_trace_log_lvl() to use the new unwinder") The task pointer argument to show_stack_log_lvl() in show_stack() was inadvertently changed to 'current'. Fixes: e18bcccd1a4e ("x86/dumpstack: Convert show_trace_log_lvl() to use the new unwinder") Signed-off-by: Josh Poimboeuf --- arch/x86/kernel/dumpstack.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/x86/kernel/dumpstack.c b/arch/x86/kernel/dumpstack.c index 999de3b..9b7cf5c 100644 --- a/arch/x86/kernel/dumpstack.c +++ b/arch/x86/kernel/dumpstack.c @@ -164,7 +164,7 @@ void show_stack(struct task_struct *task, unsigned long *sp) if (!sp && task == current) sp = get_stack_pointer(current, NULL); - show_stack_log_lvl(current, NULL, sp, ""); + show_stack_log_lvl(task, NULL, sp, ""); } void show_stack_regs(struct pt_regs *regs) -- 2.7.4