From: Salil Mehta <salil.mehta@huawei.com>
To: <dledford@redhat.com>
Cc: <salil.mehta@huawei.com>, <xavier.huwei@huawei.com>,
<oulijun@huawei.com>, <yisen.zhuang@huawei.com>,
<mehta.salil.lnk@gmail.com>, <xuwei5@hisilicon.com>,
<linux-rdma@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<linuxarm@huawei.com>, Peter Chen <luck.chen@huawei.com>
Subject: [PATCH V2 for-next 14/19] IB/hns: Validate mtu when modified qp
Date: Tue, 20 Sep 2016 17:07:07 +0100 [thread overview]
Message-ID: <20160920160712.1190216-15-salil.mehta@huawei.com> (raw)
In-Reply-To: <20160920160712.1190216-1-salil.mehta@huawei.com>
From: Lijun Ou <oulijun@huawei.com>
The mtu should be validated when modify qp,so we check it.
Signed-off-by: Lijun Ou <oulijun@huawei.com>
Signed-off-by: Peter Chen <luck.chen@huawei.com>
Reviewed-by: Wei Hu (Xavier) <xavier.huwei@huawei.com>
Signed-off-by: Salil Mehta <salil.mehta@huawei.com>
---
PATCH V2: Addressed Leon Romanovsky's comments
Link: https://lkml.org/lkml/2016/9/13/39
PATCH V1: Initial Submit
---
drivers/infiniband/hw/hns/hns_roce_qp.c | 15 +++++++++++++++
1 file changed, 15 insertions(+)
diff --git a/drivers/infiniband/hw/hns/hns_roce_qp.c b/drivers/infiniband/hw/hns/hns_roce_qp.c
index dd1b214..6a38909 100644
--- a/drivers/infiniband/hw/hns/hns_roce_qp.c
+++ b/drivers/infiniband/hw/hns/hns_roce_qp.c
@@ -32,6 +32,7 @@
*/
#include <linux/platform_device.h>
+#include <rdma/ib_addr.h>
#include <rdma/ib_umem.h>
#include "hns_roce_common.h"
#include "hns_roce_device.h"
@@ -657,6 +658,7 @@ int hns_roce_modify_qp(struct ib_qp *ibqp, struct ib_qp_attr *attr,
struct device *dev = &hr_dev->pdev->dev;
int ret = -EINVAL;
int p;
+ enum ib_mtu active_mtu;
mutex_lock(&hr_qp->mutex);
@@ -687,6 +689,19 @@ int hns_roce_modify_qp(struct ib_qp *ibqp, struct ib_qp_attr *attr,
}
}
+ if (attr_mask & IB_QP_PATH_MTU) {
+ p = attr_mask & IB_QP_PORT ? (attr->port_num - 1) : hr_qp->port;
+ active_mtu = iboe_get_mtu(hr_dev->iboe.netdevs[p]->mtu);
+
+ if (attr->path_mtu > IB_MTU_2048 ||
+ attr->path_mtu < IB_MTU_256 ||
+ attr->path_mtu > active_mtu) {
+ dev_err(dev, "attr path_mtu(%d)invalid while modify qp",
+ attr->path_mtu);
+ goto out;
+ }
+ }
+
if (attr_mask & IB_QP_MAX_QP_RD_ATOMIC &&
attr->max_rd_atomic > hr_dev->caps.max_qp_init_rdma) {
dev_err(dev, "attr max_rd_atomic invalid.attr->max_rd_atomic=%d\n",
--
1.9.1
next prev parent reply other threads:[~2016-09-20 16:10 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-20 16:06 [PATCH V2 for-next 00/19] IB/hns: Fixes for various misc. bugs Salil Mehta
2016-09-20 16:06 ` [PATCH V2 for-next 01/19] IB/hns: Remove unused parameters in some functions Salil Mehta
2016-09-20 16:06 ` [PATCH V2 for-next 02/19] IB/hns: Remove parameters of resize cq Salil Mehta
2016-09-20 16:06 ` [PATCH V2 for-next 03/19] IB/hns: Fix bug of using uninit refcount and free Salil Mehta
2016-09-20 16:06 ` [PATCH V2 for-next 04/19] IB/hns: Simplify function of pd alloc and qp alloc Salil Mehta
2016-09-20 16:06 ` [PATCH V2 for-next 05/19] IB/hns: Remove unused parameter named qp_type Salil Mehta
2016-09-20 16:06 ` [PATCH V2 for-next 06/19] IB/hns: Fix bug of clear hem Salil Mehta
2016-09-20 16:07 ` [PATCH V2 for-next 07/19] IB/hns: Delete the sqp_start from the structure hns_roce_caps Salil Mehta
2016-09-20 16:07 ` [PATCH V2 for-next 08/19] IB/hns: Optimize code of aeq and ceq interrupt handle and fix the bug of qpn Salil Mehta
2016-09-20 16:07 ` [PATCH V2 for-next 09/19] IB/hns: Modify the init of iboe lock Salil Mehta
2016-09-20 16:07 ` [PATCH V2 for-next 10/19] IB/hns: Fix bug of memory leakage for registering user mr Salil Mehta
2016-09-20 16:07 ` [PATCH V2 for-next 11/19] IB/hns: Return bad wr while post send failed Salil Mehta
2016-09-20 16:07 ` [PATCH V2 for-next 12/19] IB/hns: The Ack timeout need a lower limit value Salil Mehta
2016-09-20 16:07 ` [PATCH V2 for-next 13/19] IB/hns: Some items of qpc need to take user param Salil Mehta
2016-09-20 16:07 ` Salil Mehta [this message]
2016-09-20 16:07 ` [PATCH V2 for-next 15/19] IB/hns: Cq has not been freed Salil Mehta
2016-09-20 16:07 ` [PATCH V2 for-next 16/19] IB/hns: Update the rq head when modify qp state Salil Mehta
2016-09-20 16:07 ` [PATCH V2 for-next 17/19] IB/hns: Fix the bug when platform_get_resource() exec fail Salil Mehta
2016-09-20 16:07 ` [PATCH V2 for-next 18/19] IB/hns: Delete the redundant lines in hns_roce_v1_m_qp() Salil Mehta
2016-09-20 16:07 ` [PATCH V2 for-next 19/19] IB/hns: Fix for removal of redundant code Salil Mehta
2016-09-22 13:37 ` [PATCH V2 for-next 00/19] IB/hns: Fixes for various misc. bugs Leon Romanovsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160920160712.1190216-15-salil.mehta@huawei.com \
--to=salil.mehta@huawei.com \
--cc=dledford@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=linuxarm@huawei.com \
--cc=luck.chen@huawei.com \
--cc=mehta.salil.lnk@gmail.com \
--cc=oulijun@huawei.com \
--cc=xavier.huwei@huawei.com \
--cc=xuwei5@hisilicon.com \
--cc=yisen.zhuang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®