From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756014AbcIUISq (ORCPT ); Wed, 21 Sep 2016 04:18:46 -0400 Received: from mail-wm0-f52.google.com ([74.125.82.52]:38028 "EHLO mail-wm0-f52.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755329AbcIUISn (ORCPT ); Wed, 21 Sep 2016 04:18:43 -0400 Date: Wed, 21 Sep 2016 10:11:50 +0200 From: Michal Hocko To: Chen Gang Cc: akpm@linux-foundation.org, minchan@kernel.org, vbabka@suse.cz, mgorman@techsingularity.net, gi-oh.kim@profitbricks.com, opensource.ganesh@gmail.com, hughd@google.com, kirill.shutemov@linux.intel.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Chen Gang Subject: Re: [PATCH] mm: migrate: Return false instead of -EAGAIN for dummy functions Message-ID: <20160921081149.GE10300@dhcp22.suse.cz> References: <1474096836-31045-1-git-send-email-chengang@emindsoft.com.cn> <20160917154659.GA29145@dhcp22.suse.cz> <57E05CD2.5090408@emindsoft.com.cn> <20160920080923.GE5477@dhcp22.suse.cz> <57E1B2F4.5070009@emindsoft.com.cn> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <57E1B2F4.5070009@emindsoft.com.cn> User-Agent: Mutt/1.6.0 (2016-04-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed 21-09-16 06:06:44, Chen Gang wrote: > On 9/20/16 16:09, Michal Hocko wrote: [...] skipping the large part of the email because I do not have a spare time to discuss this. > > So what is the point of this whole exercise? Do not take me wrong, this > > area could see some improvements but I believe that doing int->bool > > change is not just the right thing to do and worth spending both your > > and reviewers time. > > > > I am not quite sure about that. Maybe you should listen to the feedback your are getting. I do not think I am not the first one here. Look, MM surely needs some man power. There are issues to be solved, patches to review. Doing the cleanups is really nice but there are more serious problems to solve first. If you want to help then starting with review would be much much more helpful and hugely appreciated. We are really lacking people there a _lot_. Just generating more work for reviewers with something that doesn't make any real difference in the runtime is far less helpful IMHO. Thanks. -- Michal Hocko SUSE Labs