From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S933498AbcIULf2 (ORCPT <rfc822;w@1wt.eu>);
        Wed, 21 Sep 2016 07:35:28 -0400
Received: from mx1.redhat.com ([209.132.183.28]:34994 "EHLO mx1.redhat.com"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S933448AbcIULfY (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 21 Sep 2016 07:35:24 -0400
Date: Wed, 21 Sep 2016 06:35:16 -0500
From: Josh Poimboeuf <jpoimboe@redhat.com>
To: Andy Lutomirski <luto@amacapital.net>
Cc: Thomas Gleixner <tglx@linutronix.de>, "H. Peter Anvin" <hpa@zytor.com>,
        Nilay Vaish <nilayvaish@gmail.com>,
        the arch/x86 maintainers <x86@kernel.org>,
        Ingo Molnar <mingo@kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Brian Gerst <brgerst@gmail.com>, Peter Zijlstra <peterz@infradead.org>,
        Linus Torvalds <torvalds@linux-foundation.org>
Subject: Re: [PATCH 3/9] x86/entry/32: fix the end of the stack for newly
 forked tasks
Message-ID: <20160921113516.rutcda4fadszs6eb@treble>
References: <cover.1474400222.git.jpoimboe@redhat.com>
 <1eabc8a9fb0ad0eb827aab23e03283fc853a5a43.1474400222.git.jpoimboe@redhat.com>
 <CAMzpN2g4jZQC=voWm42Jq407B1w2qPhRtqA0_DmFnpiyA=wDrw@mail.gmail.com>
 <20160921032516.ah3etafe4po4wfxu@treble>
 <CALCETrUeHQhRQm93pjwZfM9Oc=A8cA2_Cw4WyAirc+bxJf==yg@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <CALCETrUeHQhRQm93pjwZfM9Oc=A8cA2_Cw4WyAirc+bxJf==yg@mail.gmail.com>
User-Agent: Mutt/1.6.0.1 (2016-04-01)
X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.31]); Wed, 21 Sep 2016 11:35:18 +0000 (UTC)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, Sep 20, 2016 at 11:39:35PM -0700, Andy Lutomirski wrote:
> > And the ia64 entry code has some similar language:
> >
> >                 /*
> >                  * Invoke schedule_tail(task) while preserving in0-in7, which may be needed
> >                  * in case a system call gets restarted.
> >                  */
> >         GLOBAL_ENTRY(ia64_invoke_schedule_tail)
> >                 ...
> 
> That comment has to be wrong.  What syscall could possibly be
> restarted across schedule_tail()?  It's a brand new thread and has
> literally never done a syscall.

Hm, yeah, that comment doesn't make any sense.

> There may be another reason that the registers are live there, but I
> generally do my best to never look at ia64 asm code.

Yeah, I'm just going to turn around, pretend I never saw it, and slowly
walk away...

-- 
Josh