From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934027AbcIUUka (ORCPT ); Wed, 21 Sep 2016 16:40:30 -0400 Received: from smtpoutz28.laposte.net ([194.117.213.103]:53151 "EHLO smtp.laposte.net" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S933255AbcIUUk3 (ORCPT ); Wed, 21 Sep 2016 16:40:29 -0400 X-Greylist: delayed 1389 seconds by postgrey-1.27 at vger.kernel.org; Wed, 21 Sep 2016 16:40:28 EDT From: =?UTF-8?q?Vincent=20Stehl=C3=A9?= To: dmaengine@vger.kernel.org Cc: linux-kernel@vger.kernel.org, =?UTF-8?q?Vincent=20Stehl=C3=A9?= , Zhangfei Gao , Vinod Koul , stable@vger.kernel.org Subject: [PATCH] dmaengine: k3dma: fix off by one Date: Wed, 21 Sep 2016 22:16:55 +0200 Message-Id: <20160921201655.19674-1-vincent.stehle@laposte.net> X-Mailer: git-send-email 2.9.3 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-VR-SrcIP: 88.178.86.202 X-VR-FullState: 0 X-VR-Score: -100 X-VR-Cause-1: gggruggvucftvghtrhhoucdtuddrfeelvddrtddvgddugeehucetufdoteggodetrfdotffvucfrrhho X-VR-Cause-2: fhhilhgvmecunfetrffquffvgfenuceurghilhhouhhtmecuhedttdenucesvcftvggtihhpihgvnhht X-VR-Cause-3: shculddquddttddmnecujfgurhephffvufffkffogggtgfesthekredtredtjeenucfhrhhomhepgghi X-VR-Cause-4: nhgtvghnthcuufhtvghhlhoruceovhhinhgtvghnthdrshhtvghhlhgvsehlrghpohhsthgvrdhnvght X-VR-Cause-5: qeenucfkphepkeekrddujeekrdekiedrvddtvdenucfrrghrrghmpehmohguvgepshhmthhpohhuthdp X-VR-Cause-6: hhgvlhhopehrohhmuhgrlhgurdgsvghrghgvrhhivgdpihhnvghtpeekkedrudejkedrkeeirddvtddv X-VR-Cause-7: pdhmrghilhhfrhhomhepvhhinhgtvghnthdrshhtvghhlhgvsehlrghpohhsthgvrdhnvghtpdhrtghp X-VR-Cause-8: thhtohepshhtrggslhgvsehvghgvrhdrkhgvrhhnvghlrdhorhhg X-VR-AvState: No X-VR-State: 0 X-VR-State: 0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org In k3_of_dma_simple_xlate(), the d->chans[] array has d->dma_requests elements so > should be >=. Fixes: 8e6152bc660e69f5 ("dmaengine: Add hisilicon k3 DMA engine driver") Signed-off-by: Vincent Stehlé Cc: Zhangfei Gao Cc: Vinod Koul Cc: stable@vger.kernel.org --- drivers/dma/k3dma.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/dma/k3dma.c b/drivers/dma/k3dma.c index aabcb79..cd7f67b 100644 --- a/drivers/dma/k3dma.c +++ b/drivers/dma/k3dma.c @@ -792,7 +792,7 @@ static struct dma_chan *k3_of_dma_simple_xlate(struct of_phandle_args *dma_spec, struct k3_dma_dev *d = ofdma->of_dma_data; unsigned int request = dma_spec->args[0]; - if (request > d->dma_requests) + if (request >= d->dma_requests) return NULL; return dma_get_slave_channel(&(d->chans[request].vc.chan)); -- 2.9.3