From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755344AbcIVGMJ (ORCPT ); Thu, 22 Sep 2016 02:12:09 -0400 Received: from shards.monkeyblade.net ([184.105.139.130]:55108 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755134AbcIVGMH (ORCPT ); Thu, 22 Sep 2016 02:12:07 -0400 Date: Thu, 22 Sep 2016 02:12:02 -0400 (EDT) Message-Id: <20160922.021202.1167465769111094114.davem@davemloft.net> To: tremyfr@gmail.com Cc: yisen.zhuang@huawei.com, salil.mehta@huawei.com, yankejian@huawei.com, huangdaode@hisilicon.com, lisheng011@huawei.com, xieqianqian@huawei.com, arnd@arndb.de, lipeng321@huawei.com, andrew@lunn.ch, chenny.xu@huawei.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/2] net: ethernet: hisilicon: hns: use phydev from struct net_device From: David Miller In-Reply-To: <1474403412-18748-1-git-send-email-tremyfr@gmail.com> References: <1474403412-18748-1-git-send-email-tremyfr@gmail.com> X-Mailer: Mew version 6.7 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Wed, 21 Sep 2016 23:12:06 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Philippe Reynes Date: Tue, 20 Sep 2016 22:30:11 +0200 > The private structure contain a pointer to phydev, but the structure > net_device already contain such pointer. So we can remove the pointer > phydev in the private structure, and update the driver to use the > one contained in struct net_device. > > Signed-off-by: Philippe Reynes Applied.