From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756905AbcIVMXa (ORCPT ); Thu, 22 Sep 2016 08:23:30 -0400 Received: from shards.monkeyblade.net ([184.105.139.130]:60132 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751586AbcIVMX0 (ORCPT ); Thu, 22 Sep 2016 08:23:26 -0400 Date: Thu, 22 Sep 2016 08:23:22 -0400 (EDT) Message-Id: <20160922.082322.1182869004925614678.davem@davemloft.net> To: sean.wang@mediatek.com Cc: john@phrozen.org, nbd@openwrt.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org, keyhaede@gmail.com, objelf@gmail.com Subject: Re: [PATCH net-next] net: ethernet: mediatek: use [get|set]_link_ksettings From: David Miller In-Reply-To: <1474533723-22629-1-git-send-email-sean.wang@mediatek.com> References: <1474533723-22629-1-git-send-email-sean.wang@mediatek.com> X-Mailer: Mew version 6.7 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Thu, 22 Sep 2016 05:23:25 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Date: Thu, 22 Sep 2016 16:42:03 +0800 > From: Sean Wang > > 1) use new api [get|set]_link_ksettings instead > of [get|set]_settings old ones. > > 2) dev->phydev is sure being ready before calling > these callbacks, so removing all the sanity check > if it is existing. > > Signed-off-by: Sean Wang Applied.