From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754835AbcIVMch (ORCPT ); Thu, 22 Sep 2016 08:32:37 -0400 Received: from shards.monkeyblade.net ([184.105.139.130]:60296 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752263AbcIVMcf (ORCPT ); Thu, 22 Sep 2016 08:32:35 -0400 Date: Thu, 22 Sep 2016 08:32:05 -0400 (EDT) Message-Id: <20160922.083205.2034005377472668654.davem@davemloft.net> To: arnd@arndb.de Cc: maheshb@google.com, dsa@cumulusnetworks.com, edumazet@google.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] ipvlan: fix building without netfilter From: David Miller In-Reply-To: <20160922094130.2154824-1-arnd@arndb.de> References: <20160922094130.2154824-1-arnd@arndb.de> X-Mailer: Mew version 6.7 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Thu, 22 Sep 2016 05:32:08 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Arnd Bergmann Date: Thu, 22 Sep 2016 11:40:52 +0200 > The new l3s mode in ipvlan relies on netfilter interfaces, but > the ipvlan driver can be configured when CONFIG_NETFILTER is disabled, > leading to a build error: > > drivers/net/ipvlan/ipvlan.h:132:22: error: 'struct nf_hook_state' declared inside parameter list will not be visible outside of this definition or declaration [-Werror] > drivers/net/ipvlan/ipvlan_main.c:14:27: error: array type has incomplete element type 'struct nf_hook_ops' > ... > > This adds a forward declaration for struct nf_hook_state, and hides > the newly added l3s code in an #ifdef. > > Fixes: 4fbae7d83c98 ("ipvlan: Introduce l3s mode") > Signed-off-by: Arnd Bergmann I'm pretty sure I applied a Kconfig patch that added the necessary dependency.