From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752302AbcIVHUs (ORCPT ); Thu, 22 Sep 2016 03:20:48 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:57577 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752099AbcIVHUr (ORCPT ); Thu, 22 Sep 2016 03:20:47 -0400 Date: Thu, 22 Sep 2016 09:20:51 +0200 From: Greg KH To: Daeseok Youn Cc: lidza.louina@gmail.com, devel@driverdev.osuosl.org, driverdev-devel@linuxdriverproject.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 03/11] staging: dgnc: missing NULL check for ioremap in Message-ID: <20160922072051.GB4333@kroah.com> References: <20160922052138.GA27193@SEL-JYOUN-D1> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160922052138.GA27193@SEL-JYOUN-D1> User-Agent: Mutt/1.7.0 (2016-08-17) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Sep 22, 2016 at 02:21:38PM +0900, Daeseok Youn wrote: > The ioremap() function can be failed, so it need to have error > handling in dgnc_do_remap(). And also the return type of > dgnc_do_remap() should be changed from "void" to "int" > > Signed-off-by: Daeseok Youn > --- > drivers/staging/dgnc/dgnc_driver.c | 31 +++++++++++++++++++++---------- > 1 file changed, 21 insertions(+), 10 deletions(-) Again, odd subject line, it seems to have been cut off.