From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756768AbcIVJrr (ORCPT ); Thu, 22 Sep 2016 05:47:47 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:36037 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754065AbcIVJrn (ORCPT ); Thu, 22 Sep 2016 05:47:43 -0400 Date: Thu, 22 Sep 2016 11:47:49 +0200 From: Greg Kroah-Hartman To: Richard Genoud Cc: Cyrille Pitchen , Alexandre Belloni , Nicolas Ferre , linux-arm-kernel@lists.infradead.org, linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCHv2 2/3] tty/serial: at91: fix hardware handshake with GPIOs Message-ID: <20160922094749.GA31898@kroah.com> References: <20160912094733.21501-1-richard.genoud@gmail.com> <20160912094733.21501-3-richard.genoud@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160912094733.21501-3-richard.genoud@gmail.com> User-Agent: Mutt/1.7.0 (2016-08-17) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Sep 12, 2016 at 11:47:32AM +0200, Richard Genoud wrote: > Commit 1cf6e8fc8341 ("tty/serial: at91: fix RTS line management when > hardware handshake is enabled") broke the hardware handshake when GPIOs > where used. > > Hardware handshake with GPIOs used to work before this commit because > the CRTSCTS flag (termios->c_cflag) was set, but not the > ATMEL_US_USMODE_HWHS flag (controller register) ; so hardware handshake > enabled, but not handled by the controller. > > This commit restores this behaviour. > > NB: -stable is not Cced because it doesn't cleanly apply on 4.1+ > and it will also need previous commit: > "serial: mctrl_gpio: implement mctrl_gpio_use_rtscts" > > Signed-off-by: Richard Genoud > Acked-by: Alexandre Belloni > Fixes: 1cf6e8fc8341 ("tty/serial: at91: fix RTS line management when hardware handshake is enabled") > --- > drivers/tty/serial/atmel_serial.c | 11 ++++++++--- > 1 file changed, 8 insertions(+), 3 deletions(-) This patch doesn't apply to my tree, are you sure it's up to date? Can you please refresh this whole series against linux-next and resend? thanks, greg k-h