From: Peter Zijlstra <peterz@infradead.org>
To: Zhu Yanhai <zhu.yanhai@foxmail.com>
Cc: Ingo Molnar <mingo@redhat.com>,
linux-kernel@vger.kernel.org, shanpei.csp@alibaba-inc.com,
jinli.zjl@alibaba-inc.com, Zhu Yanhai <gaoyang.zyh@taobao.com>
Subject: Re: [PATCH] sched/debug: check p->se.on_rq for 'runnable tasks'
Date: Thu, 22 Sep 2016 12:08:42 +0200 [thread overview]
Message-ID: <20160922100842.GZ5008@twins.programming.kicks-ass.net> (raw)
In-Reply-To: <1474537853-9096-1-git-send-email-zhu.yanhai@foxmail.com>
On Thu, Sep 22, 2016 at 05:50:53PM +0800, Zhu Yanhai wrote:
> From: Zhu Yanhai <gaoyang.zyh@taobao.com>
>
> I can't see why the check was removed by commit b32e86b4. Since it was not
> relevant to the subject of the commit, I guess it was just a plain typo.
No, it was very much on purpose. It shows all tasks now, which is much
more useful if you want to generate pretty pictures from the output.
Its a bit hard to make pretty pictures when tasks disappear all the
time.
next prev parent reply other threads:[~2016-09-22 10:08 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-22 9:50 Zhu Yanhai
2016-09-22 10:08 ` Peter Zijlstra [this message]
2016-09-23 3:14 ` Zhu Yanhai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160922100842.GZ5008@twins.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=gaoyang.zyh@taobao.com \
--cc=jinli.zjl@alibaba-inc.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=shanpei.csp@alibaba-inc.com \
--cc=zhu.yanhai@foxmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome