From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754835AbcIVUcG (ORCPT ); Thu, 22 Sep 2016 16:32:06 -0400 Received: from out2-smtp.messagingengine.com ([66.111.4.26]:55165 "EHLO out2-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751123AbcIVUcF (ORCPT ); Thu, 22 Sep 2016 16:32:05 -0400 X-Sasl-enc: cLqMXYZwVZuzhDZQ356ERT2cL2qedqJT1xbTs+ErTN/d 1474576323 Date: Thu, 22 Sep 2016 23:32:02 +0300 From: Andrey Utkin To: Jannik Becher Cc: gregkh@linuxfoundation.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] drivers: wlan-ng: fixed a coding style issue Message-ID: <20160922203201.33pwuzd3lncyjncf@zver> References: <20160922191146.6420-1-Becher.Jannik@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160922191146.6420-1-Becher.Jannik@gmail.com> User-Agent: Mutt/1.6.2 (2016-06-11) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Sep 22, 2016 at 09:11:46PM +0200, Jannik Becher wrote: > removed a space after a cast to obtain the coding style. > > Signed-off-by: Jannik Becher > --- > drivers/staging/wlan-ng/p80211req.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/wlan-ng/p80211req.c b/drivers/staging/wlan-ng/p80211req.c > index 40627d5..ecd2fff 100644 > --- a/drivers/staging/wlan-ng/p80211req.c > +++ b/drivers/staging/wlan-ng/p80211req.c > @@ -110,7 +110,7 @@ static void p80211req_handle_action(struct wlandevice *wlandev, u32 *data, > ----------------------------------------------------------------*/ > int p80211req_dorequest(struct wlandevice *wlandev, u8 *msgbuf) > { > - struct p80211msg *msg = (struct p80211msg *) msgbuf; > + struct p80211msg *msg = (struct p80211msg *)msgbuf; > > /* Check to make sure the MSD is running */ > if (!((wlandev->msdstate == WLAN_MSD_HWPRESENT && checkpatch.pl shows that in this file there are other occurances of style deviations - of same or other kinds. Could you please present work on wider scope, e.g. on whole wlan-ng/, or at last making this one file to pass checkpatch.pl --strict cleanly? Not that I don't appreciate this small achievement, but I believe maintainers won't merge this one, exactly because there is more work of same kind in the same file.