From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S964885AbcIWIoj (ORCPT ); Fri, 23 Sep 2016 04:44:39 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:42193 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751972AbcIWIog (ORCPT ); Fri, 23 Sep 2016 04:44:36 -0400 Date: Fri, 23 Sep 2016 10:44:39 +0200 From: Greg KH To: giannis.damigos@gmail.com Cc: markus.boehme@mailbox.org, arve@android.com, riandrews@android.com, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCHv2 5/5] staging:android:ion: Fix void function return Message-ID: <20160923084439.GA32459@kroah.com> References: <20160923080517.421-1-giannis.damigos@gmail.com> <20160923080517.421-5-giannis.damigos@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160923080517.421-5-giannis.damigos@gmail.com> User-Agent: Mutt/1.7.0 (2016-08-17) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Sep 23, 2016 at 11:05:17AM +0300, giannis.damigos@gmail.com wrote: > From: Yannis Damigos > > This patch removes the return statement of void function > > WARNING: void function return statements are not generally useful > + return; > +} > > Signed-off-by: Yannis Damigos > --- > drivers/staging/android/ion/ion_of.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/staging/android/ion/ion_of.c b/drivers/staging/android/ion/ion_of.c > index 49f052c..c930416 100644 > --- a/drivers/staging/android/ion/ion_of.c > +++ b/drivers/staging/android/ion/ion_of.c > @@ -161,7 +161,6 @@ static int rmem_ion_device_init(struct reserved_mem *rmem, struct device *dev) > static void rmem_ion_device_release(struct reserved_mem *rmem, > struct device *dev) > { > - return; > } Why have an empty release function at all? If it can be empty, you should be able to drop the function entirely, right? thanks, greg k-h