From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1034286AbcIWNex (ORCPT ); Fri, 23 Sep 2016 09:34:53 -0400 Received: from smtprelay0122.hostedemail.com ([216.40.44.122]:59576 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1034007AbcIWNeu (ORCPT ); Fri, 23 Sep 2016 09:34:50 -0400 X-Session-Marker: 726F737465647440676F6F646D69732E6F7267 X-Spam-Summary: 30,2,0,,d41d8cd98f00b204,rostedt@goodmis.org,:::::::::,RULES_HIT:41:355:379:541:599:800:960:973:988:989:1260:1277:1311:1313:1314:1345:1359:1437:1500:1515:1516:1518:1534:1541:1593:1594:1711:1730:1747:1777:1792:2393:2553:2559:2562:3138:3139:3140:3141:3142:3353:3622:3865:3866:3868:3870:3871:3872:3874:4250:4321:4362:5007:6261:7875:7903:7974:8660:10010:10400:10848:10967:11026:11232:11473:11658:11914:12043:12050:12296:12438:12555:12740:12760:13069:13148:13230:13311:13357:13439:13972:14096:14097:14181:14659:14721:21080:21212:21451:30012:30029:30054:30090:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:1:0,LFtime:10,LUA_SUMMARY:none X-HE-Tag: sort40_642991271c210 X-Filterd-Recvd-Size: 2620 Date: Fri, 23 Sep 2016 09:34:47 -0400 From: Steven Rostedt To: Masami Hiramatsu Cc: Tom Zanussi , linux-kernel@vger.kernel.org, Ingo Molnar , Namhyung Kim Subject: Re: [PATCH] ftrace: trigger: Call traceoff trigger after event recorded Message-ID: <20160923093447.15f5c33a@gandalf.local.home> In-Reply-To: <20160923221133.6ddd77b307900a02b6f15b71@kernel.org> References: <147335074530.12462.4526186083406015005.stgit@devbox> <20160923221133.6ddd77b307900a02b6f15b71@kernel.org> X-Mailer: Claws Mail 3.13.2 (GTK+ 2.24.30; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 23 Sep 2016 22:11:33 +0900 Masami Hiramatsu wrote: > Ping? Thanks for the ping. I've been hacking on other things lately that, even though I marked this as "todo", it has falling in my INBOX abyss. I'll take a look at this today. -- Steve > > On Fri, 9 Sep 2016 01:05:45 +0900 > Masami Hiramatsu wrote: > > > Call traceoff trigger after the event is recorded. > > Since current traceoff trigger is called before recording > > the event, we can not know when the trace is off by what event. > > > > Typical usecase of traceoff/traceon trigger is tracing > > function calls and trace events between a pair of events. > > For example, trace function calls between syscall entry/exit. > > In that case, it is useful if we can see the return code > > of the target syscall. > > > > Signed-off-by: Masami Hiramatsu > > --- > > kernel/trace/trace_events_trigger.c | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/kernel/trace/trace_events_trigger.c b/kernel/trace/trace_events_trigger.c > > index a975571..6721a1e8 100644 > > --- a/kernel/trace/trace_events_trigger.c > > +++ b/kernel/trace/trace_events_trigger.c > > @@ -1028,6 +1028,7 @@ static struct event_command trigger_traceon_cmd = { > > static struct event_command trigger_traceoff_cmd = { > > .name = "traceoff", > > .trigger_type = ETT_TRACE_ONOFF, > > + .flags = EVENT_CMD_FL_POST_TRIGGER, > > .func = event_trigger_callback, > > .reg = register_trigger, > > .unreg = unregister_trigger, > > > >