From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1035037AbcIWQF4 (ORCPT ); Fri, 23 Sep 2016 12:05:56 -0400 Received: from mout.kundenserver.de ([212.227.17.10]:56586 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1030326AbcIWQFy (ORCPT ); Fri, 23 Sep 2016 12:05:54 -0400 From: Arnd Bergmann To: Chris Mason , Josef Bacik , David Sterba Cc: Arnd Bergmann , Jeff Mahoney , Qu Wenruo , Filipe Manana , Omar Sandoval , Anand Jain , linux-btrfs@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] btrfs: fix btrfs_no_printk stub helper Date: Fri, 23 Sep 2016 18:05:21 +0200 Message-Id: <20160923160532.3619432-1-arnd@arndb.de> X-Mailer: git-send-email 2.9.0 X-Provags-ID: V03:K0:cYnNvr8y1LlG/uaA1QUPJvUlZ20ZRvMNQzpGyUkYVX8OEXxrRPh Qp7o5bVoOIo5aJmm6AcC4l+xODIDzBWKiyHg6ExHkabmaXzCoaRXMR0n6Uk6nWICHnMSaAf H7iOFkaLYoOO6NcYu4oey1+9y6cxoOfnCwGXsT3kZIRtOnd3Mbk7uJ2JPoKsfHUfCdl9FrY IhGjWEJlh20jasFRpYGdw== X-UI-Out-Filterresults: notjunk:1;V01:K0:Qv45BBAJ6/U=:ll0A0e8lxRWyhosHvJjIaH FLgFYA8dvIfS+k0XXbQFYbhoeHq6wUn3sGokpKCNXzho7AaP37E3U79Z56hAkcFgyx/3eJ6Rl KLKrFbIiQVUP/jfpeZKlVTH5XYD8Ibfp0MhEiyb6FjMAY6ckDSEWDwv5eqy6O8YuC+kYoB1FO fJhG3wecrTY3bGNs22OSxnFPtuoBJJAG9z6hDdEaL6KcjedQ+ujt0RJSDmOQCNE/5LEWhc3x5 RF1mHHh0DEQvlZfW8cQwa41OAnm58AFtGl0dRNqE/7+W44WZwP6KsG4vsb/+uBmILonZ9Ogyj 3AOTczMLZneVSj6Iza9CGkij12ERgtkWCOVCyAPiYW+02fTmaTCN2bLEEtRsXrgu9aj+qOILL uzSGi6ESfppp6myu12ANughed0LQHAcezfocE0VMrpKY8PUb5nEW7F2GHl4dQt+FhlKaryVQO GfhLpNKgZuqvgCLbLvPGQysweAQr6fLHuLxqbEnAE8XsiMErUMuXLrJE7TIYgKkGukXBi9hC6 d6N1GeceMCuu24IlEXNLf0/vK3p4AmELyn25d6x3jqb9Flbc4p5o5vkiycUFXfvnAXDWaOH0n dmdgAzoYXctDg6C8PCw9Kiv+3PXFBK6v0xo1+XpiZC0C0FyQcGnl7KnpJ8gIJE9TSAx5MeL2j 1jJRpeRvpHMowwjsMpOJym7XoMzDSqcsJK8HFuW7pegbFnSXWviBlpoQNmhn0PhlUIxo= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The addition of btrfs_no_printk() caused a build failure when CONFIG_PRINTK is disabled: fs/btrfs/send.c: In function 'send_rename': fs/btrfs/ctree.h:3367:2: error: implicit declaration of function 'btrfs_no_printk' [-Werror=implicit-function-declaration] This moves the helper outside of that #ifdef so it is always defined, and changes the existing #ifdef to refer to that helper as well for consistency. Fixes: 47c57058ff2c ("btrfs: btrfs_debug should consume fs_info when DEBUG is not defined") Signed-off-by: Arnd Bergmann --- fs/btrfs/ctree.h | 17 +++++++---------- 1 file changed, 7 insertions(+), 10 deletions(-) diff --git a/fs/btrfs/ctree.h b/fs/btrfs/ctree.h index e5621268c9fe..63bf4cc34626 100644 --- a/fs/btrfs/ctree.h +++ b/fs/btrfs/ctree.h @@ -3241,20 +3241,17 @@ int btrfs_parse_options(struct btrfs_root *root, char *options, unsigned long new_flags); int btrfs_sync_fs(struct super_block *sb, int wait); +static inline __printf(2, 3) +void btrfs_no_printk(const struct btrfs_fs_info *fs_info, const char *fmt, ...) +{ +} + #ifdef CONFIG_PRINTK __printf(2, 3) void btrfs_printk(const struct btrfs_fs_info *fs_info, const char *fmt, ...); -__printf(2, 3) -static inline int btrfs_no_printk(const struct btrfs_fs_info *fs_info, - const char *fmt, ...) -{ - return 0; -} #else -static inline __printf(2, 3) -void btrfs_printk(const struct btrfs_fs_info *fs_info, const char *fmt, ...) -{ -} +#define btrfs_printk(fs_info, fmt, args...) \ + btrfs_no_printk(fs_info, fmt, ##args) #endif #define btrfs_emerg(fs_info, fmt, args...) \ -- 2.9.0